ROX-33686: Update supported OpenShift version list for dynamic plugin#108995
ROX-33686: Update supported OpenShift version list for dynamic plugin#108995dvail wants to merge 1 commit intoopenshift:rhacs-docs-mainfrom
Conversation
|
@dvail: This pull request references ROX-33686 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
@dvail: This pull request references ROX-33686 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
This LGTM. Can you please change the parent branch to |
This change is specific to the 4.10 tech preview release, I believe the current text of "4.19 or later" is what will be true for 4.11 and beyond, at least for the next few releases. Also, this hasn't been merged into 4.10 yet stackrox/stackrox#19527 so FYI on timing for when to merge the docs change. |
|
🤖 Wed Mar 25 14:44:10 - Prow CI generated the docs preview: |
OK, I guess it's a judgment call on this then. The main branch is never published - the numbered branches are what gets published. So typically the current behavior (only 4.19-4.21 OCP support) would get merged to main and then cherry picked to 4.10. I understand that it would require a subsequent change when releases 4.22+ are supported (that would be CP'd to 4.11 and later ACS versions). But I would prefer to follow the established workflow of "current behavior -> rhacs-docs-main and then CP to branches" to avoid any confusion with later updates. (I assume there will be a ticket or communication later for the 4.22+ support. If not, then maybe this is a good reason to deviate from the normal workflow.) |
|
@dvail: This pull request references ROX-33686 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kcarmichael08 Totally makes sense, I'll change the base branch.
Yes definitely, I'll make a note in our epic so that this doesn't get overlooked when 4.11 is released. |
|
@dvail: This pull request references ROX-33686 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
65e26d5 to
93f7d97
Compare
93f7d97 to
7d0c45a
Compare
|
@dvail: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
4.10
Issue:
https://redhat.atlassian.net/browse/ROX-33686
Note to reviewers:
Draft docs content change for the above issue. Feel free to edit this PR, change the base branch, or cherry-pick the change into your own branch as needed!
Link to docs preview:
https://108995--ocpdocs-pr.netlify.app/openshift-acs/latest/configuration/accessing-vulnerability-information-in-web-console.html
QE review:
Additional information: