[SRVLOGIC-443] Document Kubernetes service discovery#109172
[SRVLOGIC-443] Document Kubernetes service discovery#109172briandooley merged 1 commit intoopenshift:serverless-docs-mainfrom
Conversation
openshift-ci
bot
added
the
size/L
|
🤖 Mon Mar 30 11:40:52 - Prow CI generated the docs preview: |
kaldesai
left a comment
kaldesai
left a comment
There was a problem hiding this comment.
Excellent work :)
Just a tiny nitpicks you can consider, otherwise LGTM
Peer review is complete
improvements no1 improvements no2 improvements no3 improvements no4 improvements no5 improvements no6 improvements no7 improvements no8 [SRVLOGIC-442] Document Custom podSpec definition. improvements no1 improvements no2 improvements no3 improvements no4 improvements no5 improvements no6 improvements no7 improvements no8 peer review no1 resolve conflict with 442 add include module peer review feedback no1 merge review no1
|
@ochromy: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick serverless-docs-1.36 |
|
/cherrypick serverless-docs-1.37 |
|
/cherrypick serverless-docs-1.38 |
|
@briandooley: new pull request created: #109203 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@briandooley: new pull request created: #109204 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@briandooley: new pull request created: #109205 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Version(s):
serverless-docs-1.36serverless-docs-1.37serverless-docs-1.38Issue:
Link to docs preview:
QE review: