Skip to content

OSDOCS-18561 [NETOBSERV] Final Vale Check for March 31 deadline#109361

Merged
stevsmit merged 1 commit intoopenshift:mainfrom
gwynnemonahan:OSDOCS-18561
Apr 23, 2026
Merged

OSDOCS-18561 [NETOBSERV] Final Vale Check for March 31 deadline#109361
stevsmit merged 1 commit intoopenshift:mainfrom
gwynnemonahan:OSDOCS-18561

Conversation

@gwynnemonahan
Copy link
Copy Markdown
Contributor

@gwynnemonahan gwynnemonahan commented Mar 31, 2026

OSDOCS-18561 [NETOBSERV] Final Vale Check for March 31 deadline

Version(s):
enterprise-4.20 + since migration related

Issue:
https://redhat.atlassian.net/browse/OSDOCS-18561

Link to docs preview:

QE review:
QE is not required for this PR.

Additional information:

  • This PR addresses any rules that were flagged when the Vale tool was run against all network observability files that had not been addressed by any prior Jira and corresponding PR in this Epic: https://redhat.atlassian.net/browse/OSDOCS-14479.
  • Release Notes Archive files will be removed with move to stand alone. Per Observability, since those releases all took place before the change to the release notes format, they have not been updated to fit the new format.
  • ConceptLink is being addressed separately: https://redhat.atlassian.net/browse/OSDOCS-18730. It is not required for the March 31 deadline.
  • Updates that need to be made to enterprise-4.16 to enterprise-4.19 will be handled separately.
  • If you have questions/comments, DM Gwynne.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 31, 2026
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
Comment thread modules/network-observability-predefined-metrics.adoc
Comment thread modules/network-observability-predefined-metrics.adoc
Comment thread observability/network_observability/installing-operators.adoc Outdated
Comment thread observability/network_observability/installing-operators.adoc Outdated
@gwynnemonahan gwynnemonahan force-pushed the OSDOCS-18561 branch 2 times, most recently from 1cd9527 to b7a849b Compare March 31, 2026 20:15
@gwynnemonahan
Copy link
Copy Markdown
Contributor Author

/retest

@gwynnemonahan
Copy link
Copy Markdown
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 1, 2026
Copy link
Copy Markdown
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ShaunaDiaz ShaunaDiaz added ok-to-merge and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 2, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2026
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2026
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2026
@stevsmit stevsmit added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 23, 2026
Comment thread modules/network-observability-important-flowcollector-considerations.adoc Outdated
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit merged commit d76a7e2 into openshift:main Apr 23, 2026
2 checks passed
@stevsmit
Copy link
Copy Markdown
Member

/cherry-pick enterprise-4.22

@stevsmit
Copy link
Copy Markdown
Member

/cherry-pick enterprise-4.21

@stevsmit
Copy link
Copy Markdown
Member

/cherry-pick enterprise-4.20

@stevsmit
Copy link
Copy Markdown
Member

/cherry-pick enterprise-4.19

@stevsmit
Copy link
Copy Markdown
Member

/cherry-pick enterprise-4.18

@stevsmit
Copy link
Copy Markdown
Member

/cherry-pick enterprise-4.17

@stevsmit
Copy link
Copy Markdown
Member

/cherry-pick enterprise-4.16

@openshift-cherrypick-robot
Copy link
Copy Markdown

@stevsmit: new pull request created: #110712

Details

In response to this:

/cherry-pick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@stevsmit: #109361 failed to apply on top of branch "enterprise-4.20":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details

In response to this:

/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@stevsmit: new pull request created: #110713

Details

In response to this:

/cherry-pick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@stevsmit: new pull request created: #110714

Details

In response to this:

/cherry-pick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@stevsmit: #109361 failed to apply on top of branch "enterprise-4.18":

Applying: OSDOCS-18561 [NETOBSERV] Final Vale Check for March 31 deadline
Using index info to reconstruct a base tree...
M	observability/network_observability/installing-operators.adoc
M	observability/network_observability/metrics-alerts-dashboards.adoc
Falling back to patching base and 3-way merge...
Auto-merging observability/network_observability/metrics-alerts-dashboards.adoc
Auto-merging observability/network_observability/installing-operators.adoc
CONFLICT (content): Merge conflict in observability/network_observability/installing-operators.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OSDOCS-18561 [NETOBSERV] Final Vale Check for March 31 deadline

Details

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@stevsmit: new pull request created: #110715

Details

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@stevsmit: #109361 failed to apply on top of branch "enterprise-4.16":

Applying: OSDOCS-18561 [NETOBSERV] Final Vale Check for March 31 deadline
Using index info to reconstruct a base tree...
M	observability/network_observability/installing-operators.adoc
M	observability/network_observability/metrics-alerts-dashboards.adoc
Falling back to patching base and 3-way merge...
Auto-merging observability/network_observability/metrics-alerts-dashboards.adoc
CONFLICT (content): Merge conflict in observability/network_observability/metrics-alerts-dashboards.adoc
Auto-merging observability/network_observability/installing-operators.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OSDOCS-18561 [NETOBSERV] Final Vale Check for March 31 deadline

Details

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stevsmit
Copy link
Copy Markdown
Member

/cherry-pick enterprise-4.20

@openshift-cherrypick-robot
Copy link
Copy Markdown

@stevsmit: new pull request created: #110729

Details

In response to this:

/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants