Skip to content

[OSDOCS-17889] CQA jobs fixing all errors and warnings for OSD upgrading#109367

Merged
EricPonvelle merged 1 commit intoopenshift:mainfrom
fmcdonal:OSDOCS-17889
Apr 1, 2026
Merged

[OSDOCS-17889] CQA jobs fixing all errors and warnings for OSD upgrading#109367
EricPonvelle merged 1 commit intoopenshift:mainfrom
fmcdonal:OSDOCS-17889

Conversation

@fmcdonal
Copy link
Copy Markdown
Contributor

@fmcdonal fmcdonal commented Mar 31, 2026 •
edited
Loading

Version(s):
4.21+

Issue:
Parent story: https://redhat.atlassian.net/browse/OSDOCS-17889

  1. https://redhat.atlassian.net/browse/OSDOCS-18869 - acronyms
  2. https://redhat.atlassian.net/browse/OSDOCS-18937 - apostrophes
  3. https://redhat.atlassian.net/browse/OSDOCS-18940 - quotation
  4. https://redhat.atlassian.net/browse/OSDOCS-18941 - xref
  5. https://redhat.atlassian.net/browse/OSDOCS-18943 - replace prior to
  6. https://redhat.atlassian.net/browse/OSDOCS-18944 - remove as well as
  7. https://redhat.atlassian.net/browse/OSDOCS-18946 - replace transition
  8. https://redhat.atlassian.net/browse/OSDOCS-18948- remove in the event
  9. https://redhat.atlassian.net/browse/OSDOCS-18952 - fix PV acroynm
  10. https://redhat.atlassian.net/browse/OSDOCS-18953 - Expand CVE acronym

Link to docs preview:
OSD Upgrading

QE review:
N/A

Additional information:
Using the CQA Assessment Toolkit, this PR corrects errors, warnings, and a lot of the issues within the Upgrading book for the openshift-dedicated distribution.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 31, 2026
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Mar 31, 2026 •
edited
Loading

🤖 Wed Apr 01 08:56:24 - Prow CI generated the docs preview:

https://109367--ocpdocs-pr.netlify.app/openshift-dedicated/latest/upgrading/osd-upgrades.html

@fmcdonal fmcdonal changed the title [OSDOCS-17889] Corrected Cloud Expert Tutorials for OSD for CQA jobs ixing all errors and warnings for OSD upgrading [OSDOCS-17889] CQA jobs fixing all errors and warnings for OSD upgrading Mar 31, 2026
EricPonvelle
EricPonvelle reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small items but nothing game stopping.

Comment thread modules/upgrade.adoc Outdated
Comment thread .vale.ini Outdated
temp-ifdef = YES
temp-ifndef = NO
temp-ifeval = temp No newline at end of file
MinAlertLevel = warning
Copy link
Copy Markdown
Contributor

@EricPonvelle EricPonvelle Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this to the original with git checkout upstream/main -- .vale.ini so that we don't share this with the OCP repo.

Comment thread claude-install.sh Outdated
@@ -0,0 +1,158 @@
#!/bin/bash
Copy link
Copy Markdown
Contributor

@EricPonvelle EricPonvelle Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to your .gitignore file since we don't want this in our repo.

@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2026
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Mar 31, 2026
View reviewed changes
Comment thread upgrading/osd-upgrades.adoc Outdated
EricPonvelle
EricPonvelle reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026
@EricPonvelle EricPonvelle added branch/enterprise-4.21 branch/enterprise-4.22 and removed lgtm Indicates that a PR is ready to be merged. labels Mar 31, 2026
@fmcdonal
fixing all errors and warnings for OSDD upgrading
a15658c 
bringing in the vale file

remove line from  vale file

xref was already in additional resorces under life cycle module so removing
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 1, 2026

@fmcdonal: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@EricPonvelle EricPonvelle merged commit 80d752e into openshift:main Apr 1, 2026
2 checks passed
@EricPonvelle
Copy link
Copy Markdown
Contributor

EricPonvelle commented Apr 1, 2026

/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 1, 2026

@EricPonvelle: #109367 failed to apply on top of branch "enterprise-4.21":

Applying: fixing all errors and warnings for OSDD upgrading
Using index info to reconstruct a base tree...
M	modules/.vale.ini
Falling back to patching base and 3-way merge...
Auto-merging modules/.vale.ini
CONFLICT (content): Merge conflict in modules/.vale.ini
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fixing all errors and warnings for OSDD upgrading
Details

In response to this:

/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 1, 2026

@EricPonvelle: #109367 failed to apply on top of branch "enterprise-4.22":

Applying: fixing all errors and warnings for OSDD upgrading
Using index info to reconstruct a base tree...
M	modules/.vale.ini
Falling back to patching base and 3-way merge...
Auto-merging modules/.vale.ini
CONFLICT (content): Merge conflict in modules/.vale.ini
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fixing all errors and warnings for OSDD upgrading
Details

In response to this:

/cherrypick enterprise-4.21
/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Apr 1, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EricPonvelle EricPonvelle EricPonvelle left review comments

+1 more reviewer

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@EricPonvelle EricPonvelle

Labels

branch/enterprise-4.21 branch/enterprise-4.22 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fmcdonal @ocpdocs-previewbot @EricPonvelle @openshift-cherrypick-robot @ocpdocs-vale-bot