OSDOCS-18936: adds MCP server registration to MCP gateway#109444
OSDOCS-18936: adds MCP server registration to MCP gateway#109444ShaunaDiaz merged 1 commit intoopenshift:mcp-gateway-docs-tpfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ShaunaDiaz: This pull request references OSDOCS-18936 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ShaunaDiaz: This pull request references OSDOCS-18936 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
size/L
|
@ShaunaDiaz: This pull request references OSDOCS-18936 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Mon Apr 13 12:36:56 - Prow CI generated the docs preview: https://109444--ocpdocs-pr.netlify.app/ |
ShaunaDiaz
changed the title
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
ShaunaDiaz
changed the title
|
@ShaunaDiaz: This pull request references OSDOCS-18936 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ShaunaDiaz: This pull request references OSDOCS-18936 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ShaunaDiaz
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
👀 |
|
@ShaunaDiaz: This pull request references OSDOCS-18936 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ShaunaDiaz: This pull request references OSDOCS-18936 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
looks good! only thing we may want to consider is incorporating |
|
@ShaunaDiaz: This pull request references OSDOCS-18936 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ShaunaDiaz
added
do-not-merge/hold
|
@ShaunaDiaz: This pull request references OSDOCS-18936 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ShaunaDiaz
removed
the
merge-review-needed
|
Looking good! I just had a few comments, mostly other thoughts on format/style and such. |
mburke5678
removed
the
merge-review-in-progress
ShaunaDiaz
force-pushed
the
OSDOCS-18936
branch
3 times, most recently
from
ac252c8 to
7bf9af4
Compare
trepel
left a comment
trepel
left a comment
There was a problem hiding this comment.
A few small suggestions, other than that, looks good to me.
| ---- | ||
| $ curl -s -D /tmp/mcp_headers -X POST http://mcp.127-0-0-1.sslip.io:8001/mcp \ | ||
| -H "Content-Type: application/json" \ | ||
| -d '{"jsonrpc": "2.0", "id": 1, "method": "initialize", "params": {"protocolVersion": "2025-06-18", "capabilities": {}, "clientInfo": {"name": "test-client", "version": "1.0.0"}}}' |
There was a problem hiding this comment.
replace 2025-06-18 with 2025-11-25, this was recently fixed in upstream guide: https://github.com/Kuadrant/mcp-gateway/blob/main/docs/guides/register-mcp-servers.md
There was a problem hiding this comment.
Which makes me think, is there any process for updating upstream guides based on feedback here? If not, maybe we should introduce one...probably best would be to have a skill and/or slash command for this, wdyt?
There was a problem hiding this comment.
That's a great idea. No idea how we'd implement it, but I game to experiment.
| name: _<mcp_api_key_server_route>_ | ||
| namespace: _<mcp_test>_ | ||
| labels: | ||
| mcp-server: 'true' |
There was a problem hiding this comment.
I think this label is not used at all. It should be removed from upstream docs too. @jasonmadigan am I correct on this?
There was a problem hiding this comment.
yea that label isn't used by our controller. should be removed.
ShaunaDiaz
removed
the
do-not-merge/hold
ShaunaDiaz
force-pushed
the
OSDOCS-18936
branch
from
7bf9af4 to
5a3fa40
Compare
|
@ShaunaDiaz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@ShaunaDiaz: This pull request references OSDOCS-18936 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7 participants
Version:
mcp-gateway-docs-tp
Issue:
https://redhat.atlassian.net/browse/OSDOCS-18936
Link to docs preview:
https://109444--ocpdocs-pr.netlify.app/rhcl/latest/mcp_gateway_config/mcp-gateway-register-on-prem-mcp-servers.html
QE review:
NOTE: this PR is just for on-prem/vanilla mcp server
Additional information:
Docs merge reviewer, the
mcp-gateway-docs-tpis a Release branch, so content work is incremental. The entire branch will be integrated into therhcl-docs-main,rhcl-docs-1.3, andrhcl-docs-1.4docs in late April, and therefore, not published anywhere now.