Skip to content

NO-JIRA: Fix the "Enabling USB host passthrough" wrong procedure#110064

Open
nunnatsa wants to merge 1 commit intoopenshift:mainfrom
nunnatsa:fix-virt-usb
Open

NO-JIRA: Fix the "Enabling USB host passthrough" wrong procedure#110064
nunnatsa wants to merge 1 commit intoopenshift:mainfrom
nunnatsa:fix-virt-usb

Conversation

@nunnatsa
Copy link
Copy Markdown
Contributor

While working on #109992, I noticed a very wrong procedure with the title of "Enabling USB host passthrough"

The current "Enabling USB host passthrough procedure" is wrong in three ways:

  • First, it uses the HyperConverged jsonpatch anntoation, which is not formally supported, and is should only be use as last resort, while the HyperConverged type contain the fields to implement the procedure in a supported way.
  • Using the jsonpatch annotation, triggers an alert!
  • In addition, the verification phase is also wrong, as it checks the HyperConverged instead of the KubeVirt CR.

Version(s): v4.22, v4.21, v4.20, v4.19, v4.18

Note: cherry pick will not work for v4.18 - v4.21; but only for v4.22

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@nunnatsa: This pull request explicitly references no jira issue.

Details

In response to this:

While working on #109992, I noticed a very wrong procedure with the title of "Enabling USB host passthrough"

The current "Enabling USB host passthrough procedure" is wrong in three ways:

  • First, it uses the HyperConverged jsonpatch anntoation, which is not formally supported, and is should only be use as last resort, while the HyperConverged type contain the fields to implement the procedure in a supported way.
  • Using the jsonpatch annotation, triggers an alert!
  • In addition, the verification phase is also wrong, as it checks the HyperConverged instead of the KubeVirt CR.

Version(s): v4.22, v4.21, v4.20, v4.19, v4.18

Note: cherry pick will not work for v4.18 - v4.21; but only for v4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 14, 2026
@nunnatsa
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

@nunnatsa: once the present PR merges, I will cherry-pick it on top of enterprise-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Apr 14, 2026

@nunnatsa nunnatsa force-pushed the fix-virt-usb branch 3 times, most recently from 01ab72c to a018003 Compare April 15, 2026 12:24
The current Enabling USB host passthrough procedure is wrong in two
ways. First, it uses the HyperConverged jsonpatch anntoation, which is
not formally supported, and is should only be use as last resort, while
the HyperConverged type contain the fields to implement the procedure in
a supported way. In addition, the verification phase is also wrong, as
it checks the HyperConverged instead of the KubeVirt CR.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 15, 2026

@nunnatsa: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants