Skip to content

OSDOCS-19132: fix ifdef whoopsie (review but do not merge)#110191

Merged
jeana-redhat merged 1 commit intoopenshift:mainfrom
jeana-redhat:OSDOCS-19132-fix-callout-removal-misfire
Apr 16, 2026
Merged

OSDOCS-19132: fix ifdef whoopsie (review but do not merge)#110191
jeana-redhat merged 1 commit intoopenshift:mainfrom
jeana-redhat:OSDOCS-19132-fix-callout-removal-misfire

Conversation

@jeana-redhat
Copy link
Copy Markdown
Contributor

@jeana-redhat jeana-redhat commented Apr 15, 2026

Version(s):
4.18+ (likely, will inspect cherrypicks)

Issue:
OSDOCS-19132

Link to docs preview:

SME review:
N/A

Additional information:
Noticed while doing other work, quick fix to tiny errors from #103257
image

Please review but do not merge while I wait for version confirmation

@jeana-redhat jeana-redhat added this to the Continuous Release milestone Apr 15, 2026
@jeana-redhat jeana-redhat added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. merge-review-needed Signifies that the merge review team needs to review this PR branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 branch/enterprise-4.22 labels Apr 15, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 15, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@jeana-redhat: This pull request references OSDOCS-19132 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.16+ (confirming with CQA PR author)

Issue:
OSDOCS-19132

Link to docs preview:
🚧

SME review:
N/A

Additional information:
Noticed while doing other work, quick fix to tiny error from #103257
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2026
@jeana-redhat jeana-redhat force-pushed the OSDOCS-19132-fix-callout-removal-misfire branch from 677a4c0 to 15906dc Compare April 15, 2026 19:55
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@jeana-redhat: This pull request references OSDOCS-19132 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.16+ (confirming with CQA PR author)

Issue:
OSDOCS-19132

Link to docs preview:
🚧

SME review:
N/A

Additional information:
Noticed while doing other work, quick fix to tiny error from #103257
image

Please review but do not merge while I wait for version confirmation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@jeana-redhat: This pull request references OSDOCS-19132 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.16+ (confirming with CQA PR author)

Issue:
OSDOCS-19132

Link to docs preview:
🚧

SME review:
N/A

Additional information:
Noticed while doing other work, quick fix to tiny error from #103257
image

Please review but do not merge while I wait for version confirmation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@jeana-redhat: This pull request references OSDOCS-19132 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.16+ (confirming with CQA PR author)

Issue:
OSDOCS-19132

Link to docs preview:
🚧

SME review:
N/A

Additional information:
Noticed while doing other work, quick fix to tiny errors from #103257
image

Please review but do not merge while I wait for version confirmation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 15, 2026

@jeana-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2026

@jeana-redhat: This pull request references OSDOCS-19132 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.16+ (confirming with CQA PR author)

Issue:
OSDOCS-19132

Link to docs preview:

SME review:
N/A

Additional information:
Noticed while doing other work, quick fix to tiny errors from #103257
image

Please review but do not merge while I wait for version confirmation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added ok-to-merge and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 16, 2026
Copy link
Copy Markdown
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 16, 2026

@jeana-redhat: This pull request references OSDOCS-19132 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Version(s):
4.18+ (likely, will inspect cherrypicks)

Issue:
OSDOCS-19132

Link to docs preview:

SME review:
N/A

Additional information:
Noticed while doing other work, quick fix to tiny errors from #103257
image

Please review but do not merge while I wait for version confirmation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@jeana-redhat: once the present PR merges, I will cherry-pick it on top of enterprise-4.12, enterprise-4.13, enterprise-4.14, enterprise-4.15, enterprise-4.16, enterprise-4.17, enterprise-4.18, enterprise-4.19, enterprise-4.20, enterprise-4.21, enterprise-4.22 in new PRs and assign them to you.

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16
/cherrypick enterprise-4.15
/cherrypick enterprise-4.14
/cherrypick enterprise-4.13
/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jeana-redhat jeana-redhat merged commit 2adb2a8 into openshift:main Apr 16, 2026
2 checks passed
@jeana-redhat jeana-redhat removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 16, 2026
@jeana-redhat
Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link
Copy Markdown

@jeana-redhat: new pull request created: #110252

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@jeana-redhat: new pull request created: #110254

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@jeana-redhat: new pull request created: #110255

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@jeana-redhat: new pull request created: #110256

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@jeana-redhat: new pull request created: #110257

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@jeana-redhat: new pull request created: #110258

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@jeana-redhat: new pull request created: #110259

Details

In response to this:

/cherrypick enterprise-4.22
/cherrypick enterprise-4.21
/cherrypick enterprise-4.20
/cherrypick enterprise-4.19
/cherrypick enterprise-4.18
/cherrypick enterprise-4.17
/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 branch/enterprise-4.22 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-merge size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants