OSDOCS-19126_RN#adding BM RN#111483
Merged
ShaunaDiaz merged 1 commit intoMay 14, 2026
Merged
Conversation
openshift-ci
Bot
added
the
size/S
brendan-daly-red-hat
force-pushed
the
OSDOCS-19126_RN
branch
from
83d8260 to
e6e2060
Compare
|
🤖 Wed May 13 14:22:51 - Prow CI generated the docs preview: |
brendan-daly-red-hat
force-pushed
the
OSDOCS-19126_RN
branch
3 times, most recently
from
4a993f5 to
004db90
Compare
Contributor
Author
|
@sgoveas @MahnoorAsghar, PTAL |
| Instructions: Add entries in the following format: | ||
|
|
||
| Item description:: | ||
| With this release, the `BareMetalHost` resource now includes the Peripheral Component Interconnect (PCI) address for each network interface controller (NIC) in the `HardwareData` object. An example value for the `pciAddress` field is `0000:00:03.0`. |
There was a problem hiding this comment.
The PCI address info for a NIC may be found in these 2 separate CustomResources:
- in the BMH status.hardware.nics[] section
- in the HardwareData CR, in the spec.hardware.nics[] section
Note: The information in the BMH status.hardware section is the same as the info in the HardwareData spec.hardware, but these are 2 separate CRs.
This statement makes it sound like the HardwareData 'object' is in the BMH status, which is incorrect.
Contributor
Author
There was a problem hiding this comment.
@MahnoorAsghar, I've updated the draft text. PTAL.
brendan-daly-red-hat
force-pushed
the
OSDOCS-19126_RN
branch
from
004db90 to
908a84c
Compare
brendan-daly-red-hat
force-pushed
the
OSDOCS-19126_RN
branch
from
10e4c7f to
a00b28e
Compare
|
@brendan-daly-red-hat: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
Contributor
Author
|
/label merge-review-needed |
openshift-ci
Bot
added
the
merge-review-needed
ShaunaDiaz
reviewed
May 14, 2026
Contributor
ShaunaDiaz
left a comment
ShaunaDiaz
left a comment
There was a problem hiding this comment.
an extras space in there, but beyond minor
LGTM
| Instructions: Add entries in the following format: | ||
|
|
||
| Item description:: | ||
| With this release, the Peripheral Component Interconnect (PCI) address for each network interface controller (NIC) is available in two separate custom resources (CRs). The PCI address is located in the `status.hardware.nics[]` section of the `BareMetalHost` CR and in the `spec.hardware.nics[]` section of the `HardwareData` CR. While these are separate resources, the values in the `pciAddress` fields, for example `0000:00:03.0`, are identical. |
Contributor
There was a problem hiding this comment.
Suggested change
| With this release, the Peripheral Component Interconnect (PCI) address for each network interface controller (NIC) is available in two separate custom resources (CRs). The PCI address is located in the `status.hardware.nics[]` section of the `BareMetalHost` CR and in the `spec.hardware.nics[]` section of the `HardwareData` CR. While these are separate resources, the values in the `pciAddress` fields, for example `0000:00:03.0`, are identical. | |
| With this release, the Peripheral Component Interconnect (PCI) address for each network interface controller (NIC) is available in two separate custom resources (CRs). The PCI address is located in the `status.hardware.nics[]` section of the `BareMetalHost` CR and in the `spec.hardware.nics[]` section of the `HardwareData` CR. While these are separate resources, the values in the `pciAddress` fields, for example `0000:00:03.0`, are identical. |
ShaunaDiaz
removed
the
merge-review-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version:
4.22
Issue:
https://redhat.atlassian.net/browse/OSDOCS-19126
Link to docs preview:
Support for the PCI addresses of NICs in BareMetalHost hardware data
QE review:
Additional information:
Doc PR for this release note: #110891.