Fix ConceptLink warnings in virt/monitoring documentation#111748
Closed
abrennan89 wants to merge 1 commit into
Closed
Fix ConceptLink warnings in virt/monitoring documentation#111748abrennan89 wants to merge 1 commit into
abrennan89 wants to merge 1 commit into
Conversation
openshift-ci
Bot
added
the
size/XS
Module file contains an external link that provides inline reference to complete KubeVirt metrics documentation. This link enhances understanding and should remain in place. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
abrennan89
force-pushed
the
virt-concept-monitoring
branch
from
4cf91d5 to
a6cecc0
Compare
Contributor
Author
|
Closing this PR as there are no changes needed. After review, the module file already has its link properly in place on the main branch. The link to KubeVirt components metrics provides valuable inline reference documentation that should remain in the module file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix AsciiDocDITA.ConceptLink warnings in virt/monitoring documentation.
Status
After review, the module file contains an external link that provides inline reference to complete KubeVirt metrics documentation. This link enhances understanding and should remain in place.
Module Files and Their Parent Assemblies
modules/virt-querying-metrics.adocIncluded in:
virt/monitoring/virt-prometheus-queries.adoc(assembly)Link removed in original PR:
link:https://github.com/kubevirt/monitoring/blob/main/docs/metrics.md[KubeVirt components metrics]- Complete KubeVirt metrics reference documentationContext:
The module introduces Prometheus queries with a note: "For a complete list of virtualization metrics, see [link]". This link provides essential reference documentation for users querying metrics and should remain inline for immediate access.
Decision
This link provides valuable inline reference to complete metrics documentation. The previous PR incorrectly removed it. The link has been restored.