[OSDOCS-19880]Change nodeSelector key/pair in postgres deployment example#112138
Open
reivaj84 wants to merge 2 commits into
Open
[OSDOCS-19880]Change nodeSelector key/pair in postgres deployment example#112138reivaj84 wants to merge 2 commits into
reivaj84 wants to merge 2 commits into
Conversation
…-family label doesn't exists in a fresh ocp 4.22 install on gcp
openshift-ci
Bot
added
the
size/XS
| claimName: my-pvc <2> | ||
| ---- | ||
| <1> Specifies the machine family. In this example, it is `n4`. | ||
| <1> Specifies the instance type. In this example, it is `n4-standard-4`. |
Collaborator
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
|
@reivaj84: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change nodeSelector key/pair in postgres deployment example. machine-family label doesn't exists in a fresh ocp 4.22 install on gcp
Version(s):
OpenShift 4.22-rc4
Issue:
https://redhat.atlassian.net/browse/OSDOCS-19880
Link to docs preview:
QE review:
Additional information:
The "Example deployment YAML file" mentioned in https://content-preview.docs.redhat.com/en/documentation/openshift_container_platform/4.22/html/storage/using-container-storage-interface-csi#persistent-storage-csi-gcp-hyperdisk-storage-pools-procedure_persistent-storage-csi-gcp-pd for the postgres deployment ask the user to use the 'cloud.google.com/machine-family: n4' as the label for the nodeSelector field. In a fresh OCP 4.22-rc4 install , there is no label.
In this case, we can use the label 'node.kubernetes.io/instance-type' with value 'n4-standard-4'.
This allows the deployment to start, otherwise it will get stuck in pending waiting for a node with that specific label.