Initial Jenkins S2I documentation#1316
Merged
adellape merged 1 commit intoopenshift:masterfrom Mar 3, 2016
Merged
Conversation
Contributor
Author
mfojtik
force-pushed
the
jenkins-s2i-docs
branch
from
3d338cf to
6ec7a9e
Compare
Contributor
Author
|
@bparees comments addressed, thanks! |
Contributor
|
looks good to me, ready for @openshift/team-documentation |
mfojtik
force-pushed
the
jenkins-s2i-docs
branch
from
6ec7a9e to
600d6bb
Compare
Contributor
| "sourceStrategy": { | ||
| "from": { | ||
| "kind": "ImageStreamTag", | ||
| "name": "jenkins-1-centos7:latest" |
Contributor
There was a problem hiding this comment.
I take it for OSE we should conditionalize this to instead just show jenkins:latest?
$ oc get istag -n openshift | grep jenkins
jenkins:1 registry.access.redhat.com/openshift3/jenkins-1-rhel7:latest 2 weeks ago 3634ee8eec8ac268a86133e1ee560bdaa7453dd566e86c08e2402c82145d8d8f
jenkins:latest registry.access.redhat.com/openshift3/jenkins-1-rhel7:latest 2 weeks ago 3634ee8eec8ac268a86133e1ee560bdaa7453dd566e86c08e2402c82145d8d8f
Contributor
There was a problem hiding this comment.
actually it should just always say jenkins:latest, good catch.
it should also have "namespace: openshift"
Contributor
There was a problem hiding this comment.
@mfojtik I'll merge after the above 2 items are addressed.
Contributor
Author
There was a problem hiding this comment.
@adellape fixed... sorry for this to take that long... I must overlook this.
Contributor
adellape
added
branch/enterprise-3.2
branch/dedicated-3.2
and removed
branch/dedicated-3.1
branch/enterprise-3.1
labels
mfojtik
force-pushed
the
jenkins-s2i-docs
branch
from
600d6bb to
e219d12
Compare
Contributor
Author
Contributor
|
@mfojtik that's correct, it will go out w/ 3.2 |
|
(fyi) tracking BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1303402 |
Contributor
|
@mfojtik 👍 Thanks. |
adellape
added a commit
that referenced
this pull request
Mar 3, 2016
Initial Jenkins S2I documentation
|
Revhistory in #1725 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.