Skip to content

CNV 1.4 Web UI update for VM and Templates #13489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vikram-redhat merged 1 commit into from
Feb 22, 2019
Merged

CNV 1.4 Web UI update for VM and Templates #13489

vikram-redhat merged 1 commit into from
Feb 22, 2019

Conversation

@aburdenthehand
Copy link
Contributor

@aburdenthehand aburdenthehand commented Jan 31, 2019

16 Procedures and 6 Reference (UI field tables) that covers the 1.4 UI update for CRUD VMs (including underlying Events, Consoles, NICs and Disks) and CRUD VM Templates.

BZ#1666251

(Still need to do an overview concept and reorganisation of the guide re: cli & web ui, but need to see 1.4 operator content first.)

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2019

Hi @aburdenthehand. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 31, 2019
@kalexand-rh
Copy link
Contributor

kalexand-rh commented Jan 31, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2019
jelkosz
jelkosz reviewed Feb 1, 2019
View reviewed changes
@aburdenthehand aburdenthehand force-pushed the cnv_web_ui_1666251 branch 3 times, most recently from b36d9a4 to 61a051b Compare February 7, 2019 01:37
@jelkosz
Copy link

jelkosz commented Feb 7, 2019

Thank you @aburdenthehand it looks good now!

alexxa
alexxa suggested changes Feb 8, 2019
View reviewed changes
Copy link

@alexxa alexxa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aburdenthehand
I'm afraid to lose comments on some discovered issues, so I'm submitting this Review, but please mind I have not completed it yet. I will need a day or two next week, please.

alexxa
alexxa reviewed Feb 11, 2019
View reviewed changes
alexxa
alexxa reviewed Feb 11, 2019
View reviewed changes
alexxa
alexxa reviewed Feb 11, 2019
View reviewed changes
alexxa
alexxa reviewed Feb 11, 2019
View reviewed changes
alexxa
alexxa reviewed Feb 11, 2019
View reviewed changes
alexxa
alexxa reviewed Feb 11, 2019
View reviewed changes
jelkosz
jelkosz reviewed Feb 11, 2019
View reviewed changes
alexxa
alexxa reviewed Feb 11, 2019
View reviewed changes
alexxa
alexxa reviewed Feb 11, 2019
View reviewed changes
@aburdenthehand aburdenthehand force-pushed the cnv_web_ui_1666251 branch 2 times, most recently from df6d017 to 9c2451b Compare February 19, 2019 06:04
@aburdenthehand
Copy link
Contributor Author

aburdenthehand commented Feb 19, 2019 •
edited
Loading

@openshift/team-documentation - please review.
19 Procedures and 6 Reference (UI field tables) that cover the 1.4 UI update for CRUD VMs (including underlying Events, Consoles, NICs and Disks) and CRUD VM Templates. Primary BZ#1666251 that spawned BZ#1673453 (renaming the NIC object)& BZ#1676572 (known issue re: restarting an importing VM).
It's on_qa but has gone through a round of QE feedback.

@vikram-redhat vikram-redhat added this to the Next Release milestone Feb 19, 2019
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Feb 19, 2019

@openshift/team-documentation PTAL

@alexxa
Copy link

alexxa commented Feb 19, 2019

@aburdenthehand There are 4 comments from me which were not resolved. Will you add changes accordingly, please?

@alexxa
Copy link

alexxa commented Feb 19, 2019

@aburdenthehand Also, within this PR, can you update two first subsections of Reference section below, please? Then, they all will start with a capital letter.

Reference

  • virtual machine wizard fields
  • virtual machine template wizard fields
  • Cloud-init fields
  • Networking fields
  • Storage fields
  • Virtual machine actions
  • Types of storage volumes for virtual machines
  • Template: PVC configuration file
  • Template: VM configuration file
  • Template: VM configuration file (DataVolume)
  • Template: DataVolume import configuration file
  • Template: DataVolume clone configuration file
  • Template: VMI configuration file for PXE booting

@vikram-redhat vikram-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 20, 2019
@aburdenthehand
Copy link
Contributor Author

aburdenthehand commented Feb 20, 2019

@alexxa - Done and done. Thanks!

@alexxa
Copy link

alexxa commented Feb 20, 2019

@aburdenthehand Looks good to me now. Thanks!

@sheriff-rh sheriff-rh self-requested a review February 20, 2019 14:31
@bergerhoffer bergerhoffer self-requested a review February 20, 2019 14:51
bergerhoffer
bergerhoffer reviewed Feb 20, 2019
View reviewed changes
@sheriff-rh
Copy link
Contributor

sheriff-rh commented Feb 20, 2019

Marking as peer review done. As mentioned in the conversation on modules/cnv_template_wizard_fields_web.adoc , I recommend changing the generic line to your suggestion:

|generic
|A general configuration that balances performance and compatibility for a broad range of workloads.

Thanks!

@sheriff-rh sheriff-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 20, 2019
alexxa
alexxa reviewed Feb 20, 2019
View reviewed changes
modules/cnv_creating_template_wizard_web.adoc Outdated
Copy link

@alexxa alexxa Feb 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aburdenthehand Hm.. This wording is not correct in this case. One can't change the Bootable disk, which is rootdisk to something else. But the rootdisk itself can be modified, if the provision source is URL. One can change its size and the Storage class. For Container source, one can modify only a name of the rootdisk, and Bootable disk will refer accordingly.

Copy link
Contributor Author

@aburdenthehand aburdenthehand Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to "You can modify the rootdisk but you cannot remove it. "
also added substep to the Storage step in procedure: ".. (Optional) Click on a disk to modify available fields. Click the ✓ button to save the update."

We could specifically call out the difference in what can be updated between container- and URL-based rootdisks but it makes this para convoluted for what should be straightforward to anyone using the wizard.

alexxa
alexxa reviewed Feb 20, 2019
View reviewed changes
alexxa
alexxa suggested changes Feb 20, 2019
View reviewed changes
Copy link

@alexxa alexxa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have to revert my Verification. I have missed one thing. Requested changes are added earlier.

@aburdenthehand
19 Procedures and 6 Reference (UI field tables) that cover the 1.4 UI…
9f90cca 
… update for CRUD VMs (including underlying Events, Consoles, NICs and Disks) and CRUD VM Templates. Primary BZ#1666251 that spawned BZ#1673453 & BZ#1676572.
@aburdenthehand
Copy link
Contributor Author

aburdenthehand commented Feb 21, 2019

All feedback incorporated.
Thanks everybody!

@vikram-redhat vikram-redhat merged commit f055a6c into openshift:master Feb 22, 2019
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Feb 22, 2019

Not to be CPed to 3.11. @aburdenthehand will submit a new one with restructured docs on Monday.

@vikram-redhat vikram-redhat mentioned this pull request Feb 22, 2019
Merged
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Feb 27, 2019

/cherrypick enterprise-3.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 27, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 27, 2019

@vikram-redhat: new pull request created: #13840

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aburdenthehand aburdenthehand deleted the cnv_web_ui_1666251 branch July 12, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@sheriff-rh sheriff-rh Awaiting requested review from sheriff-rh

+3 more reviewers

@MarSik MarSik MarSik left review comments

@jelkosz jelkosz jelkosz left review comments

@alexxa alexxa alexxa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-3.11 ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

10 participants

@aburdenthehand @openshift-ci-robot @kalexand-rh @jelkosz @vikram-redhat @alexxa @sheriff-rh @openshift-cherrypick-robot @MarSik @bergerhoffer