Skip to content

CNV virtio drivers #13584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vikram-redhat merged 1 commit into from
Feb 22, 2019
Merged

CNV virtio drivers #13584

vikram-redhat merged 1 commit into from
Feb 22, 2019

Conversation

@aburdenthehand
Copy link
Contributor

@aburdenthehand aburdenthehand commented Feb 8, 2019

New chapter to cover the virtio driver content for running Windows VMs in CNV.

@petrkotas - can you please review this for technical accuracy. Thank you

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2019

Hi @aburdenthehand. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 8, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2019

@aburdenthehand: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

New chapter to cover the virtio driver content for running Windows VMs in CNV.

@petrkotas - can you please review this for technical accuracy. Thank you

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

petrkotas
petrkotas approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@petrkotas petrkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Contains pretty much the same information as upstream doc. Thanks.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2019

@petrkotas: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

LGTM. Contains pretty much the same information as upstream doc. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

kalexand-rh commented Feb 8, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2019
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Feb 10, 2019

@aburdenthehand - is this for the 1.4 CNV release?

@aburdenthehand
Copy link
Contributor Author

aburdenthehand commented Feb 11, 2019

@vikram-redhat - yes

@aburdenthehand
Copy link
Contributor Author

aburdenthehand commented Feb 19, 2019

@openshift/team-documentation - please review.

BZ#1673785 - Windows VMs need virtio drivers to operate properly. These drivers are added as a disk that can then be used to install the drivers on a fresh or existing installation. Once installed, the disk is no longer needed and can be removed from the VM.
Thank you!!

@vikram-redhat
Copy link
Contributor

vikram-redhat commented Feb 19, 2019

@openshift/team-documentation PTAL.

@vikram-redhat vikram-redhat added this to the Next Release milestone Feb 19, 2019
@vikram-redhat vikram-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 20, 2019
@bergerhoffer bergerhoffer self-requested a review February 20, 2019 14:29
bergerhoffer
bergerhoffer reviewed Feb 20, 2019
View reviewed changes
modules/cnv_supported_virtio_drivers.adoc Outdated
Copy link
Contributor

@bergerhoffer bergerhoffer Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be at level 1 heading, but since all the others in the reference section are like this, I'm guessing it's fine.

Copy link
Contributor Author

@aburdenthehand aburdenthehand Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a bit of a legacy issue from when we converted the original kbase article into adoc for 1.3. At the moment the title levelling across CNV is a bit of a house of cards, which is definitely not ideal. Once this is released we'll sweep through all CNV modules and fix the levels, and ensure they all have the '// Module included ...' prefix.

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 20, 2019
alexxa
alexxa suggested changes Feb 20, 2019
View reviewed changes
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Feb 22, 2019

Not to be CPed to 3.11. @aburdenthehand will submit a new PR incorporating this and #13489

@aburdenthehand
BZ#1673785 - Virtio drivers for Win VMs: concept, adding them to VM a…
a8b35af 
…s disk, installation on fresh and existing VMs, removing disk from VM.
@vikram-redhat vikram-redhat merged commit f9f56cb into openshift:master Feb 22, 2019
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Feb 27, 2019

/cherrypick enterprise-3.11

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 27, 2019

@vikram-redhat: new pull request created: #13841

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 27, 2019
Merged
@aburdenthehand aburdenthehand deleted the cnv_virtio_drivers branch July 12, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

+2 more reviewers

@alexxa alexxa alexxa requested changes

@petrkotas petrkotas petrkotas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-3.11 ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

8 participants

@aburdenthehand @openshift-ci-robot @kalexand-rh @vikram-redhat @openshift-cherrypick-robot @alexxa @bergerhoffer @petrkotas