Add whitelisting docker registries#1742
Conversation
cd783e5 to
3f4165d
Compare
I guess this is up to the docker daemon running on the instances. I'll defer the answer to who know this better since I'm not familiar with Origin.
No, we don't really need the equal sign at all, but docker options take it, just a matter of style, but both with and without sign are accepted options |
|
changes LGTM |
|
Tagging team for peer review: @adellape @bfallonf @tnguyen-rh @ahardin-rh Assuming this applies to Origin as well as Enterprise, maybe @adellape knows since he's a bit closer to Origin than me? |
There was a problem hiding this comment.
I think this would need ===='s around it? Example tags?
|
@tpoitras One nit, otherwise LGTM. |
3f4165d to
1ddbc20
Compare
|
Updated as per peer review. Thank you, @bfallonf & @tnguyen-rh Good to merge once Travis is done the build confirmation. |
|
[rev_history] |
Add whitelisting docker registries
Tagging @rhatdan for Tech Review:
Added details on whitelisting docker registries as per https://bugzilla.redhat.com/show_bug.cgi?id=1307210
Pretty rendered docs build:
http://file.bne.redhat.com/tpoitras/2016/Mar15/openshift-enterprise/whitelisting-BZ1307210/install_config/install/docker_registry.html#whitelisting-docker-registries
Questions:
ADD_REGISTRY='--add-registry=registry.access.redhat.com
Because on my test machine, my /etc/sysconfig/docker file already has this line:
ADD_REGISTRY='--add-registry registry.access.redhat.com'