Skip to content

Adding release note and install procedure step for BZ 1767167 #17773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bergerhoffer merged 1 commit into from
Oct 31, 2019
Merged

Adding release note and install procedure step for BZ 1767167 #17773

bergerhoffer merged 1 commit into from
Oct 31, 2019

Conversation

@ousleyp
Copy link
Member

@ousleyp ousleyp commented Oct 31, 2019

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2019
@alexxa
Copy link

alexxa commented Oct 31, 2019

@ousleyp Looks good to me. @rthallisey agree?

bergerhoffer
bergerhoffer reviewed Oct 31, 2019
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise LGTM!

@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 31, 2019
@bergerhoffer bergerhoffer added this to the Next Release milestone Oct 31, 2019
@rthallisey
Copy link

rthallisey commented Oct 31, 2019

+1

@bergerhoffer bergerhoffer merged commit a352b5e into openshift:master Oct 31, 2019
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Oct 31, 2019

/cherrypick enterprise-4.2

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Oct 31, 2019

/cherrypick enterprise-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 31, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 31, 2019

@bergerhoffer: new pull request created: #17774

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 31, 2019
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 31, 2019

@bergerhoffer: new pull request created: #17775

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ousleyp ousleyp mentioned this pull request Oct 31, 2019
Merged
@ousleyp ousleyp deleted the quotes-bug branch March 3, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.2 branch/enterprise-4.3 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@ousleyp @alexxa @rthallisey @bergerhoffer @openshift-cherrypick-robot @openshift-ci-robot