Skip to content

Conversation

@ahardin-rh
Copy link
Contributor

@ahardin-rh ahardin-rh self-assigned this Apr 14, 2016
@ahardin-rh ahardin-rh added this to the Next Release milestone Apr 14, 2016
@ahardin-rh
Copy link
Contributor Author

@adellape @tnguyen-rh @bfallonf PTAL thanks!

@ahardin-rh ahardin-rh added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahardin-rh I got a little lost and had to reread the first sentence. Can I suggest:

"Note the matching UID between the two results."

I think the problem was that 'matches' was too far from what it's modifying (UID).

Also, from what I understand, are you talking about two different improper ways to delete a user? It seems it goes from deleting the data in the wrong order, but then talking about changing identity providers. I don't think i can see a link between the two... Maybe a little elaboration is needed.

@bfallonf
Copy link

@ahardin-rh Just the one comment from me (which I think is actually two comments...). Otherwise, LGTM 👍

@ahardin-rh ahardin-rh removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 15, 2016
@ahardin-rh ahardin-rh merged commit b28a196 into openshift:master Apr 18, 2016
@ahardin-rh
Copy link
Contributor Author

ahardin-rh commented Apr 18, 2016

[rev_history]
|link:../admin_guide/manage_users.html[Managing Users]
|New topic on how to add users, delete users, and view user and identity lists. (https://bugzilla.redhat.com/show_bug.cgi?id=1326595 [BZ#1326595])
%


toc::[]

== Adding Users
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add manual, unique IDs for headings (for example, check to make sure there's not some other heading in the repo named "adding-users").

@ahardin-rh
Copy link
Contributor Author

Follow-up PR: #1921

@adellape adellape modified the milestones: Next Release, Staging Apr 19, 2016
@bfallonf bfallonf modified the milestones: Next Release, Staging, Published - 27.04.2016 Apr 27, 2016
@ahardin-rh ahardin-rh deleted the user-deletion branch November 30, 2017 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants