Bug 1306890 : Added maximum pod and node info#1961
Conversation
There was a problem hiding this comment.
I don't know if we want to have a section on allowing over-rides here?
Also might want to craft the language to be softer, as these limits can be stretched, but we want to give customers guidance, while allowing power-users to tinker with the engine.
/cc @jeremyeder ?
There was a problem hiding this comment.
@timothysc The max-pods setting is talked about here: https://docs.openshift.com/enterprise/3.1/admin_guide/manage_nodes.html#configuring-node-resources
I think adding a section about over-riding this might be out of scope for this BZ, but we can make another and work on it.
Also, I considered changing the language to say "recommended minimums" instead of "supported minimums" but that might be against the idea of this BZ. I don't think we can have both... @timothysc @jeremyeder Do you have thoughts on this? Which to prefer?
|
The +2 and +8 are additions from the base requirements listed for the master. |
|
@timothysc Thanks for the review! I changed the +2 and +8 stuff to mention the minimum prerequisite requirements and made one comment above. Let me know what you think. |
|
Haven't forgotten about this, just haven't gotten to it yet. |
|
Only comment is to change to language to "recommended" |
|
Ok. I made that change. @timothysc @jeremyeder Let me know if there's any more thoughts. This is for 3.2, so it'd be good to get it done ASAP. |
|
@timothysc @jeremyeder This is going to have to be given the thumbs up by the Wednesday otherwise it's going to miss the 3.2 release. Is there anything particularly preventing this from merging? Do we need docs on over-riding before this can merge? |
|
Please merge, and if needed we'll follow up with another issue/PR. |
|
[rev_history] |
|
@timothysc Sure thing. Thanks for that. Let me know what followup information you want with this. We do a release every week, so we can do it anytime. |
@timothysc @jeremyeder As per #1949 and BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1306890
The max-pods stuff seems to be covered here: https://docs.openshift.com/enterprise/3.1/admin_guide/manage_nodes.html#configuring-node-resources
I do have a question about the CPU requirements. Why is it 20+2 and 50+8? Why not 22 and 58? Is there a difference between the two numbers used there? Other than that, if there's anything else, please let me know.
Thanks for the inital info in the GH issue!