Skip to content

Comments

Bug 1306890 : Added maximum pod and node info#1961

Merged
bfallonf merged 1 commit intoopenshift:masterfrom
bfallonf:bz1306890
May 10, 2016
Merged

Bug 1306890 : Added maximum pod and node info#1961
bfallonf merged 1 commit intoopenshift:masterfrom
bfallonf:bz1306890

Conversation

@bfallonf
Copy link

@timothysc @jeremyeder As per #1949 and BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1306890

The max-pods stuff seems to be covered here: https://docs.openshift.com/enterprise/3.1/admin_guide/manage_nodes.html#configuring-node-resources

I do have a question about the CPU requirements. Why is it 20+2 and 50+8? Why not 22 and 58? Is there a difference between the two numbers used there? Other than that, if there's anything else, please let me know.

Thanks for the inital info in the GH issue!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we want to have a section on allowing over-rides here?

Also might want to craft the language to be softer, as these limits can be stretched, but we want to give customers guidance, while allowing power-users to tinker with the engine.

/cc @jeremyeder ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timothysc The max-pods setting is talked about here: https://docs.openshift.com/enterprise/3.1/admin_guide/manage_nodes.html#configuring-node-resources

I think adding a section about over-riding this might be out of scope for this BZ, but we can make another and work on it.

Also, I considered changing the language to say "recommended minimums" instead of "supported minimums" but that might be against the idea of this BZ. I don't think we can have both... @timothysc @jeremyeder Do you have thoughts on this? Which to prefer?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer "recommended"

@timothysc
Copy link

The +2 and +8 are additions from the base requirements listed for the master.

@bfallonf
Copy link
Author

bfallonf commented May 3, 2016

@timothysc Thanks for the review! I changed the +2 and +8 stuff to mention the minimum prerequisite requirements and made one comment above. Let me know what you think.

@jeremyeder
Copy link
Contributor

Haven't forgotten about this, just haven't gotten to it yet.

@timothysc
Copy link

Only comment is to change to language to "recommended"

@bfallonf
Copy link
Author

bfallonf commented May 5, 2016

Ok. I made that change. @timothysc @jeremyeder Let me know if there's any more thoughts. This is for 3.2, so it'd be good to get it done ASAP.

@bfallonf
Copy link
Author

bfallonf commented May 9, 2016

@timothysc @jeremyeder This is going to have to be given the thumbs up by the Wednesday otherwise it's going to miss the 3.2 release. Is there anything particularly preventing this from merging? Do we need docs on over-riding before this can merge?

@timothysc
Copy link

Please merge, and if needed we'll follow up with another issue/PR.

@bfallonf
Copy link
Author

[rev_history]
|link:../install_config/install/prerequisites.html[Installing -> Prerequisites]
|Added prerequisite information for CPU and GB size requirements to link:../install_config/install/prerequisites.html#system-requirements[System Requirements], and Important boxes recommending the node and pod limits.
%

@bfallonf bfallonf added this to the OSE 3.2 milestone May 10, 2016
@bfallonf
Copy link
Author

@timothysc Sure thing. Thanks for that. Let me know what followup information you want with this. We do a release every week, so we can do it anytime.

@bfallonf bfallonf merged commit c7028a8 into openshift:master May 10, 2016
@bfallonf bfallonf deleted the bz1306890 branch May 10, 2016 01:22
@adellape adellape modified the milestones: OSE 3.2, Staging May 11, 2016
@adellape adellape modified the milestones: OSE 3.2 GA, Staging May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants