Skip to content

Conversation

@mburke5678
Copy link
Contributor

When investigating #20318 we found a restriction against creating projects named openshift-.
This PR adds notes to the Projects assembly and creating projects modules.
20318 addresses this issue specific to Cluster Logging where the user must create the openshift-logging Namespace using a YAML. I didn't want to add that work around in the Projects docs.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@mburke5678
Copy link
Contributor Author

@deads2k @sdodson @anpingli
You three worked on the BZ to reserve the openshift- namespaces[1]. Does it make sense to add a note to the 4.x docs stating that users cannot create an openshift- namepsace?

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1428934

@anpingli
Copy link

As I know only the cluster administer can create such namespaces. The master team may know more details. @xingxingxia could you confirm?

@xingxingxia
Copy link
Contributor

Too many manual/auto runs and on_qa bugs pushed by Dev today. Will check details next day

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master components

To be precise, use cluster components, because components like openshift-ingress etc are not master components. master usually means apiserver, controller-manager, scheduler.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not allow you to create Projects starting with openshift-

Change to

does not allow you to create Projects starting with `openshift-` and `kube-` via `oc new-project` command

Because cluster admin can oc adm new-project openshift-xxx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pods created in these namespaces that have a critical pod annotation are considered critical. As such

I don't think this is the cause. The cause is https://github.com/openshift/openshift-apiserver/blob/master/pkg/project/apiserver/registry/projectrequest/delegated/delegated.go#L100-L101 code restricts it:

ForbiddenPrefixes = []string{"openshift-", "kubernetes-", "kube-"}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xingxingxia Thank you for pointing this out. I changed the wording. I would like to have a reason for why users cannot create namespaces with openshift- and kube- Is this correct?

Projects starting with openshift- and kube host cluster components that run as pods and other infrastructure components. As such, {product-title} does not allow you to create Projects starting with openshift- or kube- using the CLI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clustre

Typo of cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xingxingxia I apologize for this typo. I did make the change. But I didn't save the file before doing the commit. Sorry to waste your time here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/using the CLI/using the oc new-project command/
As said in #20473 (comment) , cluster admin can oc adm new-project openshift-xxx, which is CLI command.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If previous parts add kube-, here need to add too for consistence.

@xingxingxia
Copy link
Contributor

Added new comments. Once addressed per the comments, the PR will be lgtm, thanks

@mburke5678 mburke5678 force-pushed the add-note-openshift-projects branch 5 times, most recently from 9c7b371 to 9cba71c Compare March 19, 2020 15:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/pods/Pods/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use .adoc in xrefs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Cut and paste error. I always do that, then wonder why Travis fails!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use .adoc in xrefs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/pods/Pods/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use .adoc in xrefs.

@adellape adellape added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 19, 2020
@mburke5678 mburke5678 force-pushed the add-note-openshift-projects branch from 9cba71c to ff1867f Compare March 19, 2020 16:38
@mburke5678 mburke5678 merged commit 7411da3 into openshift:master Mar 19, 2020
@mburke5678 mburke5678 deleted the add-note-openshift-projects branch March 19, 2020 16:44
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.2

@openshift-cherrypick-robot

@mburke5678: new pull request created: #20587

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.3

@openshift-cherrypick-robot

@mburke5678: new pull request created: #20588

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.4

@openshift-cherrypick-robot

@mburke5678: new pull request created: #20589

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.1 branch/enterprise-4.2 branch/enterprise-4.3 branch/enterprise-4.4 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants