installation: provide rd.neednet=1 when using Tang disk encryption#21177
installation: provide rd.neednet=1 when using Tang disk encryption#21177kalexand-rh merged 1 commit intoopenshift:masterfrom
Conversation
miabbott
force-pushed
the
tang_fix_neednet
branch
2 times, most recently
from
634c00c to
2ad814f
Compare
miabbott
changed the title
There was a problem hiding this comment.
I didn't know this. we should confirm with @darkmuggle
There was a problem hiding this comment.
This addition is implicitly confirmed by @darkmuggle in this comment on the linked BZ - https://bugzilla.redhat.com/show_bug.cgi?id=1819215#c5
|
LGTM |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale This change is still useful/required for customers deploying older versions of RHCOS/OCP |
openshift-ci-robot
removed
the
lifecycle/stale
|
@miabbott, if you rebase to fix that error and squash, I'll merge this change. |
miabbott
force-pushed
the
tang_fix_neednet
branch
from
2ad814f to
2bd699e
Compare
openshift-ci-robot
added
the
size/XS
|
@kalexand-rh oops, missed that conflict initially...all fixed now ⬆️ |
kalexand-rh
left a comment
kalexand-rh
left a comment
There was a problem hiding this comment.
@miabbott, will you please make one more update and squash?
miabbott
force-pushed
the
tang_fix_neednet
branch
from
2bd699e to
02a6f03
Compare
In BZ#1819215[1] an error was reported that the RHCOS nodes did not successfully reboot when Tang disk encryption was used. The root cause was the missing kernel argument `rd.neednet=1`. This updates the docs to call out the requirement on that kernel argument when using Tang for disk encryption. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1819215
miabbott
force-pushed
the
tang_fix_neednet
branch
from
02a6f03 to
d056086
Compare
|
/cherrypick enterprise-4.6 |
|
/cherrypick enterprise-4.5 |
|
@kalexand-rh: new pull request created: #26342 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kalexand-rh: new pull request created: #26343 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.4 |
|
@kalexand-rh: new pull request created: #26345 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.3 |
|
@kalexand-rh: new pull request created: #26346 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks @kalexand-rh 🙏 |
8 participants
In BZ#1819215[1] an error was reported that the RHCOS nodes did not
successfully reboot when Tang disk encryption was used. The root
cause was the missing kernel argument
rd.neednet=1.This updates the docs to call out the requirement on that kernel
argument when using Tang for disk encryption.