Skip to content

closing an open ifdef#21366

Merged
lamek merged 1 commit intoopenshift:masterfrom
lamek:closing-open-ifdef
Apr 22, 2020
Merged

closing an open ifdef#21366
lamek merged 1 commit intoopenshift:masterfrom
lamek:closing-open-ifdef

Conversation

@lamek
Copy link

@lamek lamek commented Apr 22, 2020

Closing an open ifdef. @vikram-redhat FYI.

@lamek lamek added this to the Next Release milestone Apr 22, 2020
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Apr 22, 2020

The preview will be available shortly at:

kalexand-rh
kalexand-rh reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 22, 2020
@lamek lamek merged commit f08953f into openshift:master Apr 22, 2020
@lamek
Copy link
Author

lamek commented Apr 22, 2020

/cherrypick enterprise-4.1

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2020

@lamek: new pull request created: #21369

Details

In response to this:

/cherrypick enterprise-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lamek
Copy link
Author

lamek commented Apr 22, 2020

/cherrypick enterprise-4.2

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2020

@lamek: new pull request created: #21370

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lamek
Copy link
Author

lamek commented Apr 22, 2020

/cherrypick enterprise-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2020

@lamek: new pull request created: #21371

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lamek
Copy link
Author

lamek commented Apr 22, 2020

/cherrypick enterprise-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2020

@lamek: new pull request created: #21372

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.1 branch/enterprise-4.2 branch/enterprise-4.3 branch/enterprise-4.4 peer-review-done Signifies that the peer review team has reviewed this PR

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

4 participants

@lamek @openshift-docs-preview-bot @openshift-cherrypick-robot @kalexand-rh