Follow-up to Explain Impersonation (PR#2020)#2149
Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom May 25, 2016
Merged
Follow-up to Explain Impersonation (PR#2020)#2149ahardin-rh merged 1 commit intoopenshift:masterfrom
ahardin-rh merged 1 commit intoopenshift:masterfrom
Conversation
Contributor
Author
|
@tnguyen-rh @bfallonf @tpoitras PTAL. Thanks! |
There was a problem hiding this comment.
- s/we check/{product-title} checks/
- Probably the last two sentences can be coalesced, something like: "... checks to ensure ... in namespace, and returns a 403 if that check fails." Tangentially, i'm not sure if naked "a 403" is ok. Maybe it's better to stick with the two sentences and say "If the check fails, the request fails with a 403 (Forbidden) error code." (presuming this is the 403 in question).
|
@ahardin-rh Some minor touch-ups, otherwise LGTM. 👍 |
Contributor
Author
|
@tnguyen-rh you rock! Thank you for your thoughtful comments. 🎸 🤘 |
Contributor
Author
|
[rev_history] |
|
@ahardin-rh FYI, i modified the revhist note to add "Additional Concepts -> ". |
Contributor
Author
|
@tnguyen-rh Perfect! Thank you! |
Contributor
|
See #2020 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2020