Bug 1300882, added introductory Cockpit content#2222
Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom Jun 7, 2016
Merged
Bug 1300882, added introductory Cockpit content#2222ahardin-rh merged 1 commit intoopenshift:masterfrom
ahardin-rh merged 1 commit intoopenshift:masterfrom
Conversation
Contributor
Author
|
@adellape @tnguyen-rh PTAL, with special attention to my ifdef/endif and labels. |
There was a problem hiding this comment.
A quick grep shows three hits for "[0-9] and later" and only one for "[0-9] and beyond", so maybe "and later" is (slightly) preferred. Personally, i prefer "and later" since "and beyond" brings to mind old memories.
|
@ahardin-rh One micro-quibble, otherwise LGTM. |
ahardin-rh
force-pushed
the
cockpit-overview
branch
from
fcbb825 to
f771a93
Compare
Contributor
Author
|
[rev_history] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1300882