Skip to content

Project flow modifications #23087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2020
Merged

Project flow modifications #23087

merged 1 commit into from
Jun 22, 2020

Conversation

Preeticp
Copy link
Contributor

@Preeticp Preeticp commented Jun 19, 2020 •
edited
Loading

This PR modifies the Create Project flow
This is acked by the SME
This needs to be cherry picked to 4.2, 4.3, 4.4, and 4.5

@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

vikram-raj
vikram-raj reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Preeticp. Changes LGTM.

@Preeticp
Copy link
Contributor Author

Thank you Vikram

@bobfuru bobfuru self-requested a review June 22, 2020 18:06
@bobfuru bobfuru added this to the Next Release milestone Jun 22, 2020
bobfuru
bobfuru reviewed Jun 22, 2020
View reviewed changes
Copy link
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small nits and could you also squash commits, please?

@Preeticp
Copy link
Contributor Author

Fixed all comments and squashed @bobfuru request a merge, please

bobfuru
bobfuru reviewed Jun 22, 2020
View reviewed changes
@Preeticp
project flow modifications
5f6bfde 
comma

minor edits

review edits

review edits1

review edits2

review edits3

review edits3
@bobfuru
Copy link
Contributor

bobfuru commented Jun 22, 2020

LGTM!

@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 22, 2020
@bobfuru bobfuru merged commit 304a4e6 into openshift:master Jun 22, 2020
@bobfuru
Copy link
Contributor

bobfuru commented Jun 22, 2020

/cherrypick enterprise-4.2

@bobfuru
Copy link
Contributor

bobfuru commented Jun 22, 2020

/cherrypick enterprise-4.3

@openshift-cherrypick-robot
Copy link

@bobfuru: #23087 failed to apply on top of branch "enterprise-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	modules/odc-creating-projects-using-developer-perspective.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/odc-creating-projects-using-developer-perspective.adoc
CONFLICT (content): Merge conflict in modules/odc-creating-projects-using-developer-perspective.adoc
Patch failed at 0001 project flow modifications

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru
Copy link
Contributor

bobfuru commented Jun 22, 2020

/cherrypick enterprise-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 22, 2020
Merged
@bobfuru
Copy link
Contributor

bobfuru commented Jun 22, 2020

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link

@bobfuru: new pull request created: #23183

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

@bobfuru: new pull request created: #23184

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

@bobfuru: new pull request created: #23185

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru bobfuru mentioned this pull request Jun 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@bobfuru bobfuru bobfuru left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.2 branch/enterprise-4.3 branch/enterprise-4.4 branch/enterprise-4.5 peer-review-done Signifies that the peer review team has reviewed this PR

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@Preeticp @openshift-docs-preview-bot @bobfuru @openshift-cherrypick-robot @vikram-raj