4.2 fix for PR 23087 #23186
Merged
4.2 fix for PR 23087 #23186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preeticp
reviewed
Jun 23, 2020
There was a problem hiding this comment.
Hi @bobfuru we need to add a space between kube- and 'are'. The formatting has gone awry cause of this problem. I have raised another PR to fix this in 4.3, 4.4, and 4.5. If you could add that space here for 4.2 and then merge, it would be great. Also, request you to please merge the PR for this change for the other versions: #23197
I am sorry I did not see this earlier :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for 4.2 CP merge conflict in #23087
Also relates to fix in #23197