Skip to content

Remove duplicate line from code block #23178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bergerhoffer merged 1 commit into from
Jun 22, 2020
Merged

Remove duplicate line from code block #23178

bergerhoffer merged 1 commit into from
Jun 22, 2020

Conversation

@sfortner-RH
Copy link
Contributor

@sfortner-RH sfortner-RH commented Jun 22, 2020

Removed duplicate line from code block per bug.

CP to 4.1, 4.2, 4.3, 4.4, and 4.5.

No QE required.

@bergerhoffer bergerhoffer added this to the Next Release milestone Jun 22, 2020
@bergerhoffer bergerhoffer self-requested a review June 22, 2020 18:45
bergerhoffer
bergerhoffer reviewed Jun 22, 2020
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only applying for 4.2-4.5 since 4.1 is no longer supported.

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 22, 2020
@bergerhoffer bergerhoffer merged commit 6d6e1ad into openshift:master Jun 22, 2020
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Jun 22, 2020

/cherrypick enterprise-4.5

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Jun 22, 2020

/cherrypick enterprise-4.4

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Jun 22, 2020

/cherrypick enterprise-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 22, 2020

@bergerhoffer: new pull request created: #23179

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 22, 2020

@bergerhoffer: new pull request created: #23180

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 22, 2020

@bergerhoffer: new pull request created: #23181

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 22, 2020
Merged
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Jun 22, 2020

/cherrypick enterprise-4.2

@sfortner-RH sfortner-RH deleted the BZ1847881 branch June 22, 2020 18:47
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 22, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 22, 2020

@bergerhoffer: new pull request created: #23182

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.2 branch/enterprise-4.3 branch/enterprise-4.4 branch/enterprise-4.5 peer-review-done Signifies that the peer review team has reviewed this PR

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

3 participants

@sfortner-RH @bergerhoffer @openshift-cherrypick-robot