CNV BZ#1861322 #24253
Merged
CNV BZ#1861322 #24253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
ousleyp
reviewed
Jul 28, 2020
virt/virt-2-4-release-notes.adoc
Outdated
Member
There was a problem hiding this comment.
s/creating/you create
s/using/by using
Question: should 0 be in backticks if you're referring to the value in the yaml?
Suggestion: We generally don't use parenthesis. Instead of (force stop), could you very briefly explain why 0 = force stop?
virt/virt-2-4-release-notes.adoc
Outdated
Member
There was a problem hiding this comment.
nit/suggestion: I'd swap this for Edit the common template by running the following command:
virt/virt-2-4-release-notes.adoc
Outdated
Member
There was a problem hiding this comment.
s/will be granted/is granted
s/gracefully shutdown/gracefully shut down
aburdenthehand
force-pushed
the
cnv-bz1861322-graceperiod
branch
from
4728b14 to
3c1454c
Compare
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
QE ackd in a pre-release jira (cnv-4934) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known issue plus workaround for common-templates bug
Docs bug: https://bugzilla.redhat.com/show_bug.cgi?id=1861322
Eng bug: https://bugzilla.redhat.com/show_bug.cgi?id=1861297
@rmohr can you please review
Edit: adding screenshot of build
