Skip to content

Conversation

@aburdenthehand
Copy link
Contributor

Adding ID to specific (existing) known issue, and important admonition (recommended by QE) to the procedure that xrefs to the workaround

https://bugzilla.redhat.com/show_bug.cgi?id=1861322
https://bugzilla.redhat.com/show_bug.cgi?id=1861297 <-- we can remove these once the dev bz is merged.

This PR will not have a netlify build but hopefully this screenshot will suffice:
Screenshot from 2020-08-06 13-55-00
The link goes directly to the known issue so users can access the workaround.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2020
@rnetser
Copy link

rnetser commented Aug 6, 2020

/lgtm

@openshift-ci-robot
Copy link

@rnetser: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-redhat vikram-redhat added the CNV Label for all CNV PRs label Aug 6, 2020
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still not using xrefs in modules. Also, can you use the attribute instead of "OpenShift Virtualization?" And don't you need to update the template before you make the vm? I might add this content to the assembly itself before this module. (I might put in a temporary heading instead of a note so that it's easier to see. Sometimes notes in assemblies look like they're attached to the previous module.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gosh, I'm a goose. Yes, yes, and yes. Thanks for the catch(es)!
I will update as suggested.

@kalexand-rh kalexand-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Aug 6, 2020
@kalexand-rh kalexand-rh added this to the Next Release milestone Aug 6, 2020
@aburdenthehand aburdenthehand force-pushed the cnv-bz1861322-doc-grace branch from 71abe49 to 385ab33 Compare August 6, 2020 17:15
…ded by QE) to the procedure that xrefs to the workaround
@aburdenthehand aburdenthehand force-pushed the cnv-bz1861322-doc-grace branch from 385ab33 to 2cce572 Compare August 6, 2020 17:41
@aburdenthehand aburdenthehand merged commit cf43934 into openshift:enterprise-4.5 Aug 6, 2020
@aburdenthehand aburdenthehand deleted the cnv-bz1861322-doc-grace branch July 12, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants