OSDOCS-1208: Adding pod network connectivity checks to release notes #24927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
bergerhoffer
added
branch/enterprise-4.6
peer-review-needed
Contributor
Author
|
@sanchezl Here's the release notes entry if you can please review. Preview (internal): http://file.rdu.redhat.com/~ahoffer/2020/OSDOCS-1208/release_notes/ocp-4-6-release-notes.html#ocp-4-6-pod-network-connectivity-checks |
sanchezl
approved these changes
Aug 20, 2020
jboxman
reviewed
Aug 20, 2020
Contributor
There was a problem hiding this comment.
@bergerhoffer, this is implemented by a CRD:
From oc api-resources:
podnetworkconnectivitychecks controlplane.operator.openshift.io true PodNetworkConnectivityCheck
So as of today at least, wouldn't this not use back ticks and s/resources/custom resources/?
Contributor
Author
There was a problem hiding this comment.
@jboxman technically yes, but I tend to just use "resource" because I don't think the distinction is important.
mburke5678
reviewed
Aug 20, 2020
Contributor
|
One nit. LGTM |
bergerhoffer
force-pushed
the
OSDOCS-1208
branch
from
3537594 to
01d033f
Compare
Contributor
Author
|
@xingxingxia Are you the right person to review this? I wasn't sure since https://issues.redhat.com/browse/MSTR-1008 doesn't have a QE assignee set. Thanks! |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OSDOCS-1208
Preview (internal): http://file.rdu.redhat.com/~ahoffer/2020/OSDOCS-1208/release_notes/ocp-4-6-release-notes.html#ocp-4-6-pod-network-connectivity-checks