Conversation
openshift-ci-robot
added
the
size/M
|
The preview will be available shortly at: |
|
@igor-karpukhin PTAL |
|
@sichvoge Do you this level of information is sufficient or do we need more? |
|
@igor-karpukhin PTAL |
mburke5678
force-pushed
the
logging-cluster-labels-2
branch
from
8e188f8 to
ff4e4ac
Compare
|
@QiaolingTang Can you please review this PR for me? Thank you! |
There was a problem hiding this comment.
@mburke5678 we can add several labels here, so A label is not accurate.
The labels can be added like:
labels:
name1: value1
name2: value2
...
cd3be50 to
a07a15c
Compare
kalexand-rh
left a comment
kalexand-rh
left a comment
There was a problem hiding this comment.
I have a request and a suggestion. This is looking good. :)
There was a problem hiding this comment.
I might add the annotation to this line, too, or add expand the description to acknowledge that each pipeline definition contains an optional label. (Please apply any changes that you make to this YAML to the other YAML examples that you've changed, except the last one.)
There was a problem hiding this comment.
| You can add labels to outbound log messages using `key:value` pairs in the pipeline. For example, you could add a label to messages forwarded to others data centers or label the logs by type. Labels added to objects are also forwarded with the log message. | |
| You can add labels to outbound log messages by using `key:value` pairs in the pipeline. For example, you might add a label to messages that are forwarded to others data centers or label the logs by type. Labels that are added to objects are also forwarded with the log message. |
kalexand-rh
added
the
peer-review-done
mburke5678
force-pushed
the
logging-cluster-labels-2
branch
from
29785c6 to
28f3653
Compare
|
/cherrypick enterprise-4.6 |
|
@mburke5678: new pull request created: #26308 DetailsIn response to this: >/cherrypick enterprise-4.6 Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
https://issues.redhat.com/browse/OSDOCS-1213
https://issues.redhat.com/browse/LOG-825
https://issues.redhat.com/browse/LOG-717