Skip to content

SRVKE-562: Added Kafka install docs #26450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbarbeevargas merged 1 commit into from
Nov 6, 2020
Merged

SRVKE-562: Added Kafka install docs #26450

lbarbeevargas merged 1 commit into from
Nov 6, 2020

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Oct 14, 2020 •
edited
Loading

  • ODC install docs for Knative Kafka
  • YAML install docs for Knative Kafka

OCP 4.6+

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2020
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Oct 14, 2020

The preview will be available shortly at:

matzew
matzew reviewed Oct 22, 2020
View reviewed changes
@matzew
Copy link
Member

matzew commented Oct 22, 2020

I think I miss content from this doc:
https://docs.google.com/document/d/10ZjrPDwg95KwfoLwXMzGq3r3O0v99oq7aE5zhh9RCKc/edit#heading=h.b1li9dog74dy

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2020
matzew
matzew reviewed Oct 26, 2020
View reviewed changes
matzew
matzew reviewed Oct 26, 2020
View reviewed changes
@matzew
Copy link
Member

matzew commented Oct 26, 2020

added comments, but looks good so far!

maschmid
maschmid reviewed Oct 27, 2020
View reviewed changes
maschmid
maschmid reviewed Oct 27, 2020
View reviewed changes
@abrennan89 abrennan89 force-pushed the SRVKE-562 branch 2 times, most recently from f87ebe9 to 831d91b Compare October 27, 2020 14:01
@abrennan89 abrennan89 requested a review from maschmid October 27, 2020 14:02
@maschmid
Copy link
Contributor

maschmid commented Oct 29, 2020

QE approved

@abrennan89
Copy link
Contributor Author

abrennan89 commented Oct 29, 2020

NOTE: Need to add TP blurb for Kafka, will do this, and also comment out sections for merging if this is before 1.11.0 release.

@Preeticp do you want to do a quick review of this before I send it for OCP peer review? 🙂 thanks

Preeticp
Preeticp reviewed Oct 30, 2020
View reviewed changes
Copy link
Contributor

@Preeticp Preeticp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abrennan89 I have left a few suggestions. Otherwise it looks good to me.

@Preeticp Preeticp mentioned this pull request Nov 2, 2020
Merged
@abrennan89 abrennan89 changed the title [WIP] Added Kafka docs SRVKE-562: Added Kafka install docs Nov 2, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2020
@lbarbeevargas lbarbeevargas self-requested a review November 2, 2020 20:37
@lbarbeevargas lbarbeevargas added this to the Next Release milestone Nov 2, 2020
lbarbeevargas
lbarbeevargas reviewed Nov 2, 2020
View reviewed changes
Copy link
Contributor

@lbarbeevargas lbarbeevargas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to review modules/serverless-install-kafka-odc.adoc, but wanted to share by initial comments before I sign off for the day. This is looking good! A few wording suggestions so far.

@lbarbeevargas lbarbeevargas added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 2, 2020
lbarbeevargas
lbarbeevargas reviewed Nov 3, 2020
View reviewed changes
Copy link
Contributor

@lbarbeevargas lbarbeevargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abrennan89 A few more comments. Great job on this!

@lbarbeevargas lbarbeevargas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 3, 2020
@abrennan89 abrennan89 force-pushed the SRVKE-562 branch 2 times, most recently from 70ea524 to 408ccd1 Compare November 5, 2020 19:25
lbarbeevargas
lbarbeevargas reviewed Nov 5, 2020
View reviewed changes
Copy link
Contributor

@lbarbeevargas lbarbeevargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments/catches. Otherwise, LGTM!

@lbarbeevargas
Copy link
Contributor

lbarbeevargas commented Nov 6, 2020

@abrennan89 Merging this. Please feel free to tag me in the corresponding new PR that uncomments the Using Apache Kafka with OpenShift Serverless assembly.

@lbarbeevargas lbarbeevargas merged commit 351bfef into openshift:master Nov 6, 2020
@lbarbeevargas
Copy link
Contributor

lbarbeevargas commented Nov 6, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 6, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 6, 2020 •
edited by openshift-ci-robot
Loading

@lbarbeevargas: new pull request created: #27164

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lbarbeevargas
Copy link
Contributor

lbarbeevargas commented Nov 6, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 6, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 6, 2020 •
edited by openshift-ci-robot
Loading

@lbarbeevargas: new pull request created: #27165

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the SRVKE-562 branch December 17, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Preeticp Preeticp Preeticp left review comments

@maschmid maschmid Awaiting requested review from maschmid

+3 more reviewers

@matzew matzew matzew left review comments

@sjwoodman sjwoodman sjwoodman left review comments

@lbarbeevargas lbarbeevargas lbarbeevargas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

9 participants

@abrennan89 @openshift-docs-preview-bot @matzew @maschmid @lbarbeevargas @openshift-cherrypick-robot @sjwoodman @Preeticp @openshift-ci-robot