Skip to content

Conversation

@lbarbeevargas
Copy link
Contributor

@lbarbeevargas lbarbeevargas commented Oct 27, 2020

BZ-1844449 - https://bugzilla.redhat.com/show_bug.cgi?id=1844449

Updates to the hostname value fluentd-4nzfz in examples when "Forwarding logs using the syslog protocol". The correct value is ${hostname}. This PR covers the update to 4.4. Cluster logging was restructured, so updates to 4.5 and 4.6 will be made in separate PRs.

PR for 4.6
PR for 4.5

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2020
@openshift-docs-preview-bot

@lbarbeevargas lbarbeevargas changed the title BZ-1844449 Updating hostname in syslog protocol examples BZ-1844449 Updating hostname in syslog protocol examples 4.4 Oct 30, 2020
@lbarbeevargas
Copy link
Contributor Author

lbarbeevargas commented Oct 30, 2020

Copy link

@anpingli anpingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020
@lbarbeevargas lbarbeevargas added this to the Next Release milestone Nov 3, 2020
@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Nov 3, 2020
@bobfuru
Copy link
Contributor

bobfuru commented Nov 3, 2020

LGTM!

@lbarbeevargas lbarbeevargas force-pushed the BZ1844449-4-4-correct-hostname-forwarding-logs-syslog-protocol branch from 50ea512 to d21e4ed Compare November 6, 2020 21:27
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@lbarbeevargas
Copy link
Contributor Author

Confirmed update per https://bugzilla.redhat.com/show_bug.cgi?id=1844449#c2. Merging.

@lbarbeevargas lbarbeevargas merged commit 961d0b3 into openshift:enterprise-4.4 Nov 6, 2020
@lbarbeevargas lbarbeevargas deleted the BZ1844449-4-4-correct-hostname-forwarding-logs-syslog-protocol branch November 6, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.4 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants