adding log forwarding and links to Understanding cluster logging #26899
Conversation
openshift-ci-robot
added
the
size/S
|
The preview will be available shortly at: |
|
@sichvoge WDYT? |
mburke5678
force-pushed
the
logging-add-components
branch
from
433d907 to
e2fdefd
Compare
bobfuru
left a comment
bobfuru
left a comment
There was a problem hiding this comment.
A few comments but otherwise LGTM!
logging/cluster-logging.adoc
Outdated
There was a problem hiding this comment.
"For more information, see..." (To avoid redundancy here?)
And same suggestion for the other xref additions here that are repeating the same wording.
logging/cluster-logging.adoc
Outdated
There was a problem hiding this comment.
I believe we are now using lowercase here ("Cluster Logging custom resource"), per the note that was updated in our guidelines:
You can use "object", "resource", "custom resource", "spec", etc. as appropriate after the object reference. This is especially recommended if it helps with clarity or readability.
There was a problem hiding this comment.
@bobfuru
Agreed. I left it upper-case as it appears that way throughout the logging docs. I should do a universal change.
bobfuru
added
the
peer-review-done
mburke5678
force-pushed
the
logging-add-components
branch
from
e2fdefd to
4ee9daa
Compare
|
/cherrypick enterprise-4.5 |
|
@mburke5678: new pull request created: #27025 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.6 |
|
@mburke5678: new pull request created: #27026 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.7 |
|
@mburke5678: new pull request created: #27747 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Addding links to configuring page for each component and added log forwarding to the understanding cluster logging page.