Bug 1787281, Added Optimizing networking section #26917

ahardin-rh · 2020-10-29T20:40:48Z

https://bugzilla.redhat.com/show_bug.cgi?id=1787281

@chaitanyaenr PTAL

openshift-docs-preview-bot · 2020-10-29T20:43:32Z

The preview will be available shortly at:

https://network-optimization--ocpdocs.netlify.com/

jboxman · 2020-10-29T21:41:15Z

modules/optimizing-mtu-networking.adoc

In OCP 4.x, the MTU is configured at install time only.

This is where it happens:

https://docs.openshift.com/container-platform/4.6/installing/installing_aws/installing-aws-network-customizations.html#modifying-nwoperator-config-startup_installing-aws-network-customizations

jboxman · 2020-10-29T21:42:00Z

modules/optimizing-mtu-networking.adoc

This looks like it's from Ansible for 3.11? This is inapplicable in 4.x.

The MTU information is available here:

https://docs.openshift.com/container-platform/4.6/networking/cluster-network-operator.html#nw-operator-cr_cluster-network-operator

jboxman · 2020-10-29T21:45:01Z

modules/optimizing-mtu-networking.adoc

So I'd keep the MTU discussion possibly, but omit the procedure and note that this must happen during cluster installation only.

And the MTU size varies between OpenShift SDN and OVN-Kubernetes; We now offer both as of 4.6 GA.

jboxman · 2020-10-29T21:46:30Z

scalability_and_performance/optimizing-networking.adoc

It probably makes sense to include OVN-Kubernetes as well.

However, it uses Geneve / GENEVE instead of VXLAN as the tunnel protocol.

ahardin-rh · 2020-11-06T03:19:15Z

@chaitanyaenr @jboxman I made some updates. PTAL and let me know if we're getting closer 😄

jboxman · 2020-11-06T04:05:10Z

modules/optimizing-mtu-networking.adoc

We seem to have excised SDN mostly from the docs, because reasons. OpenShift SDN is a legacy name. Lately, it's called the cluster network provider. (Such as OpenShift SDN cluster network provider.) So I'd say

and the cluster network MTU.

jboxman · 2020-11-06T04:05:35Z

modules/optimizing-mtu-networking.adoc

s/0must/must/

jboxman · 2020-11-06T04:07:50Z

modules/optimizing-mtu-networking.adoc

This is all handled internally now; Previously in OCP 3.x it was somewhat manual.

So I'd omit entirely the second paragraph. No one can actually do that anymore.

jboxman · 2020-11-06T04:09:17Z

scalability_and_performance/optimizing-networking.adoc

And it's possible to xref to OVN-Kubernetes as well.

xref:../../networking/ovn_kubernetes_network_provider/about-ovn-kubernetes.adoc#about-ovn-kubernetes

jboxman · 2020-11-06T04:11:11Z

scalability_and_performance/optimizing-networking.adoc

Or these xrefs:

[id="nw-operator-configuration-parameters-for-openshift-sdn_{context}"] == Configuration parameters for the OpenShift SDN default CNI network provider

[id="nw-operator-configuration-parameters-for-ovn-sdn_{context}"] == Configuration parameters for the OVN-Kubernetes default CNI network provider

jboxman · 2020-11-06T04:12:47Z

@ahardin-rh, added a few more comments.

ahardin-rh · 2020-11-09T22:16:27Z

@jboxman Updated. Thanks for the insight!

ahardin-rh · 2020-11-09T22:18:10Z

@anuragthehatter Are you able to provide QE review or point me in the right direction? Thanks!

ahardin-rh · 2020-12-03T14:07:01Z

@mffiedler PTAL. Thank you!

mffiedler · 2020-12-03T14:55:54Z

@anuragthehatter @rbbratta Please reveiw - especially from a 3.11 -> 4.z change perspective and the addition of OVN

anuragthehatter · 2020-12-04T19:55:38Z

modules/optimizing-mtu-networking.adoc

And I believe its minus 100 bytes for OVN. We can also include it as reference for OVN as geneve/ovn is already being discussed in this doc. wdyt

@anuragthehatter I applied your suggestion. Can you please review the latest change? Thanks!

@ahardin-rh Thank you for applying the change. I guess we can put line For OVN and Geneve, the MTU must be less than the NIC MTU by 100 bytes at a minimum. after we finish sdn discussion. I means post On a jumbo frame ethernet network, set this to `8950`.. Currently seems like we are sandwiching ovn details in btw continued SDN dicussion. Will leave up to you to decide. Thank you. Rest LGTM

Thanks! I moved the OVN discussion to the right spot.

ahardin-rh · 2020-12-11T16:35:07Z

/cherrypick enterprise-4.7

ahardin-rh · 2020-12-11T16:35:29Z

/cherrypick enterprise-4.6

ahardin-rh · 2020-12-11T16:35:40Z

/cherrypick enterprise-4.5

openshift-cherrypick-robot · 2020-12-11T16:35:53Z

@ahardin-rh: new pull request created: #28048

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahardin-rh · 2020-12-11T16:35:56Z

/cherrypick enterprise-4.4

openshift-cherrypick-robot · 2020-12-11T16:35:57Z

@ahardin-rh: new pull request created: #28049

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-12-11T16:36:01Z

@ahardin-rh: new pull request created: #28050

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-12-11T16:36:10Z

@ahardin-rh: new pull request created: #28051

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahardin-rh added branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 labels Oct 29, 2020

ahardin-rh added this to the Next Release milestone Oct 29, 2020

ahardin-rh self-assigned this Oct 29, 2020

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2020

jboxman reviewed Oct 29, 2020

View reviewed changes

ahardin-rh force-pushed the network-optimization branch from 4212aa2 to 1d60140 Compare November 6, 2020 03:17

jboxman reviewed Nov 6, 2020

View reviewed changes

modules/optimizing-mtu-networking.adoc Outdated

Copy link

Contributor

jboxman Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/0must/must/

ahardin-rh reacted with thumbs up emoji

jboxman reviewed Nov 6, 2020

View reviewed changes

ahardin-rh force-pushed the network-optimization branch from 1d60140 to ef5096f Compare November 9, 2020 22:15

ahardin-rh requested a review from anuragthehatter November 9, 2020 22:18

ahardin-rh requested a review from mffiedler December 3, 2020 14:07

anuragthehatter reviewed Dec 4, 2020

View reviewed changes

ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Dec 9, 2020

ahardin-rh force-pushed the network-optimization branch from ef5096f to fc761e2 Compare December 9, 2020 22:25

Bug 1787281, Added Optimizing networking section

c8cb928

ahardin-rh force-pushed the network-optimization branch from fc761e2 to c8cb928 Compare December 11, 2020 16:14

openshift-ci-robot assigned anuragthehatter Dec 11, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020

ahardin-rh merged commit a41e510 into openshift:master Dec 11, 2020

openshift-cherrypick-robot mentioned this pull request Dec 11, 2020

[enterprise-4.7] Bug 1787281, Added Optimizing networking section #28048

Merged

openshift-cherrypick-robot mentioned this pull request Dec 11, 2020

[enterprise-4.6] Bug 1787281, Added Optimizing networking section #28049

Merged

openshift-cherrypick-robot mentioned this pull request Dec 11, 2020

[enterprise-4.5] Bug 1787281, Added Optimizing networking section #28050

Merged

openshift-cherrypick-robot mentioned this pull request Dec 11, 2020

[enterprise-4.4] Bug 1787281, Added Optimizing networking section #28051

Merged

Bug 1787281, Added Optimizing networking section #26917

Bug 1787281, Added Optimizing networking section #26917

Uh oh!

Conversation

ahardin-rh commented Oct 29, 2020

Uh oh!

openshift-docs-preview-bot commented Oct 29, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahardin-rh commented Nov 6, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jboxman commented Nov 6, 2020

Uh oh!

ahardin-rh commented Nov 9, 2020

Uh oh!

ahardin-rh commented Nov 9, 2020

Uh oh!

ahardin-rh commented Dec 3, 2020

Uh oh!

mffiedler commented Dec 3, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahardin-rh commented Dec 11, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahardin-rh commented Dec 11, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahardin-rh commented Dec 11, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Dec 11, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahardin-rh commented Dec 11, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Dec 11, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Dec 11, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Dec 11, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

ahardin-rh commented Dec 11, 2020 •

edited by openshift-ci-robot

Loading

ahardin-rh commented Dec 11, 2020 •

edited by openshift-ci-robot

Loading

ahardin-rh commented Dec 11, 2020 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Dec 11, 2020 •

edited by openshift-ci-robot

Loading

ahardin-rh commented Dec 11, 2020 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Dec 11, 2020 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Dec 11, 2020 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Dec 11, 2020 •

edited by openshift-ci-robot

Loading