Skip to content

search: unify the search button style #27029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vikram-redhat merged 1 commit into from
Nov 4, 2020
Merged

search: unify the search button style #27029

vikram-redhat merged 1 commit into from
Nov 4, 2020

Conversation

@jiri-fiala
Copy link
Contributor

@jiri-fiala jiri-fiala commented Nov 4, 2020

This unifies the search field button positioning and sizing across major browsers (fixing the button appearance in Firefox).

@vikram-redhat, please have a look and cherry-pick to merge into the right documentation branches where the search.css is served from.

@jiri-fiala
search: unify the search button style
ef3774b 
* Unifies the search button style via a uniform border.

Signed-off-by: Jiri Fiala <jfiala@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2020
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Nov 4, 2020

/lgtm

@vikram-redhat vikram-redhat merged commit ab1f221 into openshift:master Nov 4, 2020
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Nov 4, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.1

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 4, 2020

@vikram-redhat: cannot checkout enterprise-4.1: error checking out enterprise-4.1: exit status 1. output: error: pathspec 'enterprise-4.1' did not match any file(s) known to git

Details

In response to this:

/cherrypick enterprise-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 4, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 4, 2020 •
edited by openshift-ci-robot
Loading

@vikram-redhat: new pull request created: #27030

Details

In response to this:

/cherrypick enterprise-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiri-fiala jiri-fiala deleted the search-button-style branch August 24, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vikram-redhat vikram-redhat

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiri-fiala @vikram-redhat @openshift-cherrypick-robot @openshift-ci-robot