Skip to content

Comments

Bug 1368883 added info on resource limits in downward API#2740

Merged
bfallonf merged 1 commit intoopenshift:masterfrom
bfallonf:bz1368883
Sep 2, 2016
Merged

Bug 1368883 added info on resource limits in downward API#2740
bfallonf merged 1 commit intoopenshift:masterfrom
bfallonf:bz1368883

Conversation

@bfallonf
Copy link

@bfallonf bfallonf commented Aug 26, 2016

@bfallonf
Copy link
Author

@aveshagarwal FYI

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node's CPU and memory allocatables

It was changed in kubernetes/kubernetes#29639 and I also sent a doc update PR here:
https://github.com/kubernetes/kubernetes.github.io/pull/1107/files

Copy link
Author

@bfallonf bfallonf Sep 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aveshagarwal I had to Google why Atom didn't like it, but it turns out allocatables is not a word... So I changed to "allocatable values".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@bfallonf
Copy link
Author

bfallonf commented Sep 1, 2016

@aveshagarwal I've made the changes as per your suggestions. I'll presume everything else is OK and move forward, but please let me know if there's any other issues with this. Thanks!

@adellape @ahardin-rh @tpoitras Probably OK for peer review please!

@bfallonf
Copy link
Author

bfallonf commented Sep 1, 2016

[rev_history]
|xref:../dev_guide/downward_api.adoc#dev-guide-downward-api[Downward API]
|Added information on consuming container resources using the downward API.
%

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct for the volume example above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aveshagarwal OK. I removed this step.

@ahardin-rh
Copy link
Contributor

@bfallonf just a few style nits from me. Other than that, looks good! 🌟

@bfallonf
Copy link
Author

bfallonf commented Sep 2, 2016

Thanks @ahardin-rh and @aveshagarwal Suggestions put in. I'll merge away.

@bfallonf bfallonf changed the title [WIP] Bug 1368883 added info on resource limits in downward API Bug 1368883 added info on resource limits in downward API Sep 2, 2016
@bfallonf bfallonf merged commit 7efa985 into openshift:master Sep 2, 2016
@bfallonf bfallonf deleted the bz1368883 branch September 2, 2016 03:11
@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Oct 7, 2016
@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Oct 7, 2016
@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants