Bug 1368883 added info on resource limits in downward API#2740
Bug 1368883 added info on resource limits in downward API#2740bfallonf merged 1 commit intoopenshift:masterfrom
Conversation
|
@aveshagarwal FYI |
dev_guide/downward_api.adoc
Outdated
There was a problem hiding this comment.
node's CPU and memory allocatables
It was changed in kubernetes/kubernetes#29639 and I also sent a doc update PR here:
https://github.com/kubernetes/kubernetes.github.io/pull/1107/files
There was a problem hiding this comment.
@aveshagarwal I had to Google why Atom didn't like it, but it turns out allocatables is not a word... So I changed to "allocatable values".
|
@aveshagarwal I've made the changes as per your suggestions. I'll presume everything else is OK and move forward, but please let me know if there's any other issues with this. Thanks! @adellape @ahardin-rh @tpoitras Probably OK for peer review please! |
|
[rev_history] |
dev_guide/downward_api.adoc
Outdated
There was a problem hiding this comment.
This is not correct for the volume example above.
|
@bfallonf just a few style nits from me. Other than that, looks good! 🌟 |
|
Thanks @ahardin-rh and @aveshagarwal Suggestions put in. I'll merge away. |
As per: https://bugzilla.redhat.com/show_bug.cgi?id=1368883
@aveshagarwal FYI
I'll comment in the BZ.