MIG-415, MIG 416: Direct image and PV migration #27468
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
The preview will be available shortly at: |
apinnick
force-pushed
the
mig416-direct-image-migration
branch
from
ad3e1b8 to
e14c218
Compare
openshift-ci-robot
added
the
needs-rebase
apinnick
force-pushed
the
mig416-direct-image-migration
branch
from
e14c218 to
f1c8c81
Compare
openshift-ci-robot
removed
the
needs-rebase
apinnick
force-pushed
the
mig416-direct-image-migration
branch
from
f1c8c81 to
4c3f87b
Compare
|
@apinnick please see the comments |
apinnick
force-pushed
the
mig416-direct-image-migration
branch
2 times, most recently
from
f8ecf24 to
5f1ff87
Compare
|
@xinredhat I made the changes you requested. |
apinnick
force-pushed
the
mig416-direct-image-migration
branch
from
5f1ff87 to
397e34d
Compare
|
@apinnick LGTM |
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
| * *Cluster name*: May contain lower-case letters (`a-z`) and numbers (`0-9`). Must not contain spaces or international characters. | ||
| * *Url*: URL of the cluster's API server, for example, `\https://<master1.example.com>:8443`. | ||
| * *Service account token*: String that you obtained from the source cluster. | ||
| * *Exposed route to image registry*: Optional. You can specify a route to the image registry of your source cluster to enable direct migration for images, for example, `docker-registry-default.apps.cluster.com`. |
There was a problem hiding this comment.
Suggestion: s/Exposed/Expose
There was a problem hiding this comment.
No. That changes the meaning.
First, the markup indicates that this is the UI. Documentation must follow the UI, not vice versa.
Second, the field refers to an "exposed route". It's not a procedure step. The user has exposed a route to the image registry and needs to enter the route in this field.
|
|
||
| * *Copy* copies the data in a source cluster's PV to the replication repository and then restores it on a newly created PV, with similar characteristics, in the target cluster. | ||
| . Select a *Source cluster*, a *Target cluster*, and a *Repository*, and click *Next*. | ||
| . In the *Namespaces* screen, select the projects to be migrated and click *Next*. |
There was a problem hiding this comment.
Suggestion: add colons after Copy and Move
There was a problem hiding this comment.
No. Copy and Move are the subjects of the verb "copies" and make grammatical sense. There is no reason to turn these sentences into fragments.
|
Just a couple of suggestions, otherwise LGTM! |
|
@bmcelvee Comments addressed. Please merge and CP. |
|
/cherrypick enterprise-4.5 |
|
/cherrypick enterprise-4.6 |
|
/cherrypick enterprise-4.7 |
|
@bmcelvee: new pull request created: #28123 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bmcelvee: new pull request created: #28124 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bmcelvee: new pull request created: #28125 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
https://issues.redhat.com/browse/MIG-415
https://issues.redhat.com/browse/MIG-416
CP to 4.5, 4.6, 4.7.
The migration plan wizard has changed considerably, so you should check the preview build.
New "exposed route" field:
https://mig416-direct-image-migration--ocpdocs.netlify.app/openshift-enterprise/latest/migration/migrating_3_4/migrating-applications-with-cam-3-4.html#migration-adding-cluster-to-cam_migrating-3-4
Creating a migration plan:
https://mig416-direct-image-migration--ocpdocs.netlify.app/openshift-enterprise/latest/migration/migrating_3_4/migrating-applications-with-cam-3-4.html#migration-creating-migration-plan-cam_migrating-3-4