Applying new style guidelines for Install docs #27633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
|
The preview will be available shortly at: |
openshift-ci-robot
added
the
needs-rebase
codyhoag
force-pushed
the
installer-terminology
branch
from
c928dc9 to
30a5c2c
Compare
openshift-ci-robot
added
size/XXL
codyhoag
force-pushed
the
installer-terminology
branch
from
2d483eb to
dc0c228
Compare
codyhoag
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
codyhoag
force-pushed
the
installer-terminology
branch
from
dc0c228 to
2084a1c
Compare
codyhoag
added
the
peer-review-needed
jboxman
approved these changes
Dec 4, 2020
Contributor
jboxman
left a comment
jboxman
left a comment
There was a problem hiding this comment.
I've left a few comments for your review.
I do wonder about capitalizing Ingress.
modules/ipi-install-troubleshooting-cleaning-up-previous-installations.adoc
Outdated
Show resolved
Hide resolved
jboxman
added
peer-review-done
codyhoag
force-pushed
the
installer-terminology
branch
from
2084a1c to
8932a0b
Compare
Contributor
Author
|
/cherrypick enterprise-4.7 |
|
@codyhoag: #27633 failed to apply on top of branch "enterprise-4.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/cherrypick enterprise-4.6 |
|
@codyhoag: #27633 failed to apply on top of branch "enterprise-4.6": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/cherrypick enterprise-4.5 |
|
@codyhoag: #27633 failed to apply on top of branch "enterprise-4.5": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/cherrypick enterprise-4.4 |
|
@codyhoag: #27633 failed to apply on top of branch "enterprise-4.4": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was referenced Dec 4, 2020
Contributor
Author
|
Cherrypicks for 4.6/4.7 are complete. 4.4/4.5 will require a little more effort. Those are in-progress. |
This was referenced Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.