Fix #27579: Add escape for each double-quotes

[kurokobo]

• Add escape for every double-quotes
  • We don't need any quotes unless the name of the interface contains spaces, but it seems someone added them just in case in the past. So I keep all double-quotes and escape them.
  • There was also an idea to add -E to sudo command, but it's safer to expand all variables before sudo has invoked than to pass all the environment variables to root.
• Remove the second nmcli con down "$PUB_CONN" command.
  • Since the connection with this name doesn't exist at this stage, the command will be never succeeded.

[kurokobo]

@vikram-redhat Please review this PR.

[vikram-redhat]

@johnwilkins - can you take a look?

@ahardin-rh for peer review afterwards.

[iranzo]

This was handled upstream via https://github.com/openshift-kni/baremetal-deploy/pull/516/files

[ahardin-rh]

LGTM!

[ahardin-rh]

/cherrypick enterprise-4.6

[openshift-cherrypick-robot]

@ahardin-rh: new pull request created: #27937

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahardin-rh]

/cherrypick enterprise-4.7

[openshift-cherrypick-robot]

@ahardin-rh: new pull request created: #27938

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.