Skip to content

welcome: mention oVirt on OKD #27799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kalexand-rh merged 1 commit into from
Dec 2, 2020
Merged

welcome: mention oVirt on OKD #27799

kalexand-rh merged 1 commit into from
Dec 2, 2020

Conversation

@sandrobonazzola
Copy link
Contributor

@sandrobonazzola sandrobonazzola commented Dec 2, 2020

using attribute to show oVirt instead of RHV when
generating OKD documentation.

Signed-off-by: Sandro Bonazzola sbonazzo@redhat.com

@sandrobonazzola
welcome: mention oVirt on OKD
a40482b 
using attribute to show oVirt instead of RHV when
generating OKD documentation.

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2020
@kalexand-rh
Copy link
Contributor

kalexand-rh commented Dec 2, 2020

@vikram-redhat, PTAL?

@vikram-redhat
Copy link
Contributor

vikram-redhat commented Dec 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@kalexand-rh
Copy link
Contributor

kalexand-rh commented Dec 2, 2020

It looks like the attribute is in versions 4.5 and later, so I'm going to apply it to those versions.

@kalexand-rh kalexand-rh added this to the Next Release milestone Dec 2, 2020
@kalexand-rh kalexand-rh merged commit f845789 into openshift:master Dec 2, 2020
@kalexand-rh
Copy link
Contributor

kalexand-rh commented Dec 2, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.5

@kalexand-rh
Copy link
Contributor

kalexand-rh commented Dec 2, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@kalexand-rh
Copy link
Contributor

kalexand-rh commented Dec 2, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 2, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 2, 2020 •
edited by openshift-ci-robot
Loading

@kalexand-rh: new pull request created: #27806

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 2, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 2, 2020 •
edited by openshift-ci-robot
Loading

@kalexand-rh: new pull request created: #27807

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 2, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 2, 2020 •
edited by openshift-ci-robot
Loading

@kalexand-rh: new pull request created: #27808

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vikram-redhat vikram-redhat

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@sandrobonazzola @kalexand-rh @vikram-redhat @openshift-cherrypick-robot @openshift-ci-robot