Skip to content

WINC support notice and feature name update #28087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codyhoag merged 1 commit into from
Dec 15, 2020
Merged

WINC support notice and feature name update #28087

codyhoag merged 1 commit into from
Dec 15, 2020
+11 −6

Conversation

@codyhoag
Copy link
Contributor

@codyhoag codyhoag commented Dec 14, 2020 •
edited
Loading

Addressing support issues brought up in openshift/windows-machine-config-operator#226. The feature name has also been updated.

@codyhoag codyhoag added this to the Next Release milestone Dec 14, 2020
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 14, 2020
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Dec 14, 2020

The preview will be available shortly at:

@codyhoag
Copy link
Contributor Author

codyhoag commented Dec 14, 2020

@Anandnatraj PTAL

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 15, 2020
@codyhoag codyhoag changed the title WINC support notice WINC support notice and feature name update Dec 15, 2020
@codyhoag codyhoag added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 15, 2020
@codyhoag
Copy link
Contributor Author

codyhoag commented Dec 15, 2020

These changes have been ACKed by Product Management via email.

kalexand-rh
kalexand-rh reviewed Dec 15, 2020
View reviewed changes
kalexand-rh
kalexand-rh reviewed Dec 15, 2020
View reviewed changes
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one style pick, this LGTM!

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 15, 2020
@codyhoag
Copy link
Contributor Author

codyhoag commented Dec 15, 2020

@vikram-redhat @sjstout this aligns docs with the WINC updates necessary for the GA launch.

@codyhoag codyhoag merged commit e639bbd into openshift:master Dec 15, 2020
@codyhoag
Copy link
Contributor Author

codyhoag commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@codyhoag
Copy link
Contributor Author

codyhoag commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

@codyhoag: #28087 failed to apply on top of branch "enterprise-4.6":

Applying: WINC support notice
Using index info to reconstruct a base tree...
M	_topic_map.yml
Falling back to patching base and 3-way merge...
Auto-merging _topic_map.yml
CONFLICT (content): Merge conflict in _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 WINC support notice
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 15, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 15, 2020 •
edited by openshift-ci-robot
Loading

@codyhoag: new pull request created: #28121

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag codyhoag mentioned this pull request Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@codyhoag @openshift-docs-preview-bot @openshift-cherrypick-robot @kalexand-rh @openshift-ci-robot