-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-1720 bug fixes for 4-6 branch only #28331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The preview will be available shortly at:
|
6dc67f7 to
179ac31
Compare
|
@duanwei33 PTAL for QE |
|
@bobfuru Similar to the PersistentVolume CRD, the VolumeSnapshotContent CRD is a cluster resource that points to a real snapshot in the storage back end. |
179ac31 to
a315364
Compare
|
@duanwei33 - Removed Cinder, let me know if this looks good now, thanks! |
a315364 to
1dd6b9f
Compare
Good catch on this. I've updated this PR and the 4.5 PR (#28330) to conditionally reflect the additional bug fixes that were also introduced in 4.7 (#28034). |
1dd6b9f to
4c51a5a
Compare
|
/lgtm |
4c51a5a to
35dc67a
Compare
|
New changes are detected. LGTM label has been removed. |
|
@openshift/team-documentation PTAL |
sfortner-RH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
| [id="csi-drivers-supported_{context}"] | ||
| = CSI drivers supported by {product-title} | ||
|
|
||
| {product-title} installs certain CSI drivers by default, giving users storage options that are not possible with in-tree volume plug-ins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to spell out the first instance of CSI here for clarity. There doesn't seem to be a consolidated viewpoint on doing this in OCP, but if a user reaches this doc from Google will they know what that acronym stands for? I always spell out the first instance of an acronym in all of my topics, even if they are nested together in the same assembly, and then proceed with acronym throughout for this reason. But it's also a hard ingrained habit from past roles too. It's fine as it, just some thoughts :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm in total agreement. I try to spell out on first instance at the module level but missed this one, now fixed. Thanks!
35dc67a to
7d3c52b
Compare
Follow up to #28034 and to this comment that brings OCP 4.6 docs up to date for:
snapshot.storage.k8s.io/v1beta1modules/persistent-storage-csi-drivers-supported.adocusing the drivers supported up to OCP 4.6