Skip to content

Conversation

@bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Jan 4, 2021

Follow up to #28034 and to this comment that brings OCP 4.6 docs up to date for:

  • CSI snapshot controller namespace, as reported in https://bugzilla.redhat.com/show_bug.cgi?id=1906288
  • Use of snapshot apiVersion snapshot.storage.k8s.io/v1beta1
  • Adding modules/persistent-storage-csi-drivers-supported.adoc using the drivers supported up to OCP 4.6

@bobfuru bobfuru added this to the Next Release milestone Jan 4, 2021
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 4, 2021
@openshift-docs-preview-bot

The preview will be available shortly at:

@bobfuru bobfuru force-pushed the OSDOCS-1720-bugs-4-6 branch from 6dc67f7 to 179ac31 Compare January 4, 2021 21:55
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 4, 2021
@bobfuru bobfuru mentioned this pull request Jan 4, 2021
@bobfuru
Copy link
Contributor Author

bobfuru commented Jan 4, 2021

@duanwei33 PTAL for QE

@duanwei33
Copy link

@bobfuru
Is there another bz to track PersistentVolume and PersistentVolumeClaim as not a CRD?

Similar to the PersistentVolume CRD, the VolumeSnapshotContent CRD is a cluster resource that points to a real snapshot in the storage back end.
Similar to the PersistentVolumeClaim CRD, the VolumeSnapshot CRD defines a developer request for a snapshot.

@bobfuru bobfuru force-pushed the OSDOCS-1720-bugs-4-6 branch from 179ac31 to a315364 Compare January 5, 2021 19:04
@bobfuru
Copy link
Contributor Author

bobfuru commented Jan 5, 2021

@duanwei33 - Removed Cinder, let me know if this looks good now, thanks!

@bobfuru bobfuru force-pushed the OSDOCS-1720-bugs-4-6 branch from a315364 to 1dd6b9f Compare January 5, 2021 19:22
@bobfuru
Copy link
Contributor Author

bobfuru commented Jan 5, 2021

@bobfuru
Is there another bz to track PersistentVolume and PersistentVolumeClaim as not a CRD?

Similar to the PersistentVolume CRD, the VolumeSnapshotContent CRD is a cluster resource that points to a real snapshot in the storage back end.
Similar to the PersistentVolumeClaim CRD, the VolumeSnapshot CRD defines a developer request for a snapshot.

Good catch on this. I've updated this PR and the 4.5 PR (#28330) to conditionally reflect the additional bug fixes that were also introduced in 4.7 (#28034).

@duanwei33
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2021
@bobfuru bobfuru force-pushed the OSDOCS-1720-bugs-4-6 branch from 4c51a5a to 35dc67a Compare January 7, 2021 20:40
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2021
@bobfuru
Copy link
Contributor Author

bobfuru commented Jan 7, 2021

@openshift/team-documentation PTAL

@bobfuru bobfuru added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 7, 2021
Copy link
Contributor

@sfortner-RH sfortner-RH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

[id="csi-drivers-supported_{context}"]
= CSI drivers supported by {product-title}

{product-title} installs certain CSI drivers by default, giving users storage options that are not possible with in-tree volume plug-ins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to spell out the first instance of CSI here for clarity. There doesn't seem to be a consolidated viewpoint on doing this in OCP, but if a user reaches this doc from Google will they know what that acronym stands for? I always spell out the first instance of an acronym in all of my topics, even if they are nested together in the same assembly, and then proceed with acronym throughout for this reason. But it's also a hard ingrained habit from past roles too. It's fine as it, just some thoughts :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm in total agreement. I try to spell out on first instance at the module level but missed this one, now fixed. Thanks!

@bobfuru bobfuru force-pushed the OSDOCS-1720-bugs-4-6 branch from 35dc67a to 7d3c52b Compare January 7, 2021 22:16
@bobfuru bobfuru merged commit b28c5b5 into openshift:enterprise-4.6 Jan 7, 2021
@bobfuru bobfuru deleted the OSDOCS-1720-bugs-4-6 branch January 7, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 peer-review-needed Signifies that the peer review team needs to review this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants