Skip to content

Comments

Bug 1372457, explained the impact of disabling dnsmasq#2844

Merged
ahardin-rh merged 1 commit intoopenshift:masterfrom
ahardin-rh:disable-dnsmasq
Sep 21, 2016
Merged

Bug 1372457, explained the impact of disabling dnsmasq#2844
ahardin-rh merged 1 commit intoopenshift:masterfrom
ahardin-rh:disable-dnsmasq

Conversation

@ahardin-rh
Copy link
Contributor

@ahardin-rh ahardin-rh added this to the Future Release milestone Sep 14, 2016
@ahardin-rh ahardin-rh self-assigned this Sep 14, 2016
@ahardin-rh
Copy link
Contributor Author

@miheer @sferich888 PTAL. Thanks!

@ahardin-rh
Copy link
Contributor Author

Approved by QE.

@miheer @sferich888 PTAL
@adellape @bfallonf @tpoitras peer review please 🙇

@sferich888
Copy link
Contributor

@rjhowe PTAL

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahardin-rh I think I'm a little confused by the above. Should it say:

"If you want to set up X, then set openshift_use_dnsmasq in the Ansible playbook to false."

or

"If you set up X, then {product-title} sets openshift_use_dnsmasq in the Ansible playbook to false"

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks!

@bfallonf
Copy link

@ahardin-rh Would it be worth suggesting that the entire addition here be included in a Warning box or something? The previous procedure seems to use dnsmasq, so it's a bit jarring seeing this topic as a new section.

Otherwise, LGTM!

@ahardin-rh ahardin-rh force-pushed the disable-dnsmasq branch 3 times, most recently from e6c4fe5 to 2202b97 Compare September 21, 2016 15:40
@ahardin-rh
Copy link
Contributor Author

@bfallonf Thanks! I think it's a lot of information to place in a warning box, so I made it its own true section.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand this statement, are we talking about the route exposed for the registry or the SKYDNS service name. Even with out dnsmasq we should be able to use both if the cluster is configured correctly. We inject the kubernetes service ip and search domains in the container resolv.conf and take resolv.conf from the host. So we should be able to resolve everything still.

Unless things have changed in later versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjhowe Thanks. I removed the statement.

@ahardin-rh ahardin-rh merged commit a5fe6b9 into openshift:master Sep 21, 2016
@ahardin-rh
Copy link
Contributor Author

[rev_history]
|xref:../install_config/install/prerequisites.adoc#install-config-install-prerequisites[Installing -> Prerequisites]
|Added information about xref:../install_config/install/prerequisites.adoc#dns-config-prereq-disabling-dnsmasq[disabling dnsmasq].
%

@bfallonf bfallonf modified the milestones: Next Release, Staging, Weekly Release 10/04/16 Oct 4, 2016
@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Oct 7, 2016
@ahardin-rh ahardin-rh deleted the disable-dnsmasq branch November 30, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants