Skip to content

Conversation

@bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Jan 12, 2021

@bergerhoffer bergerhoffer added this to the Next Release milestone Jan 12, 2021
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2021
@bergerhoffer bergerhoffer changed the title [WIP] OSDOCS-1650: Adding docs for managing user oauth tokens OSDOCS-1650: Adding docs for managing user oauth tokens Jan 14, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2021
@bergerhoffer bergerhoffer added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 14, 2021
@bergerhoffer
Copy link
Contributor Author

@sttts I made a few adjustments based on our slack conversation if you can take another look. Especially the wording around oc logout, if that's any better. Thanks!

@rhpmali Can you also please review? Thanks!

Preview: https://osdocs-1650--ocpdocs.netlify.app/openshift-enterprise/latest/authentication/managing-oauth-access-tokens.html

Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 15, 2021
@openshift-docs-preview-bot

The preview will be available shortly at:

@bergerhoffer
Copy link
Contributor Author

Thanks @stlaz, I've updated per your comments. Let me know if the listing per client is what you were expecting.

@rhpmali Can you please QE review this? Thanks!

https://osdocs-1650--ocpdocs.netlify.app/openshift-enterprise/latest/authentication/managing-oauth-access-tokens.html

@rhpmali
Copy link

rhpmali commented Jan 25, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2021
@bergerhoffer bergerhoffer merged commit 6499498 into openshift:master Jan 25, 2021
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Jan 25, 2021

/cherrypick enterprise-4.7

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 25, 2021

@bergerhoffer: new pull request created: #28813

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer deleted the OSDOCS-1650 branch August 3, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants