CNV-5258: FS overhead space #28519
Merged
CNV-5258: FS overhead space #28519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
maya-r
reviewed
Jan 13, 2021
maya-r
reviewed
Jan 13, 2021
maya-r
reviewed
Jan 13, 2021
ousleyp
force-pushed
the
cnv-5258
branch
2 times, most recently
from
cdda565 to
0b446b4
Compare
maya-r
reviewed
Jan 14, 2021
maya-r
reviewed
Jan 14, 2021
ousleyp
force-pushed
the
cnv-5258
branch
2 times, most recently
from
732d11b to
c63c8c5
Compare
ousleyp
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
aburdenthehand
left a comment
aburdenthehand
left a comment
There was a problem hiding this comment.
Looks great. I only have a handful of nits
virt/virtual_machines/virtual_disks/virt-reserving-pvc-space-fs-overhead.adoc
Outdated
Show resolved
Hide resolved
ousleyp
added
the
peer-review-done
ousleyp
force-pushed
the
cnv-5258
branch
2 times, most recently
from
97cff3f to
7986098
Compare
|
Deploy preview for osdocs ready! Built with commit 4b52dcf |
Member
Author
|
/cherrypick enterprise-4.7 |
|
@ousleyp: new pull request created: #29010 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/CNV-5258
Preview: https://deploy-preview-28519--osdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virtual_disks/virt-reserving-pvc-space-fs-overhead.html
Code, QE, and peer review complete.