Skip to content

Warning for Azure Windows machine set name length restriction #28776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codyhoag merged 1 commit into from
Jan 25, 2021
Merged

Warning for Azure Windows machine set name length restriction #28776

codyhoag merged 1 commit into from
Jan 25, 2021

Conversation

@codyhoag
Copy link
Contributor

@codyhoag codyhoag commented Jan 22, 2021

Resolves #28774

@codyhoag codyhoag added this to the Next Release milestone Jan 22, 2021
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2021
@codyhoag
Copy link
Contributor Author

codyhoag commented Jan 22, 2021

@sgaoshang can you verify? Thanks!

@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Jan 22, 2021

The preview will be available shortly at:

@sgaoshang
Copy link

sgaoshang commented Jan 23, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2021
@sgaoshang
Copy link

sgaoshang commented Jan 23, 2021

/label qe-approved

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2021

@sgaoshang: The label(s) qe-approved cannot be applied, because the repository doesn't have them

Details

In response to this:

/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag codyhoag added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 25, 2021
bergerhoffer
bergerhoffer reviewed Jan 25, 2021
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 25, 2021
@codyhoag codyhoag merged commit cc3ec8a into openshift:master Jan 25, 2021
@codyhoag
Copy link
Contributor Author

codyhoag commented Jan 25, 2021 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@codyhoag
Copy link
Contributor Author

codyhoag commented Jan 25, 2021 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 25, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 25, 2021 •
edited by openshift-ci-robot
Loading

@codyhoag: new pull request created: #28805

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 25, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 25, 2021 •
edited by openshift-ci-robot
Loading

@codyhoag: new pull request created: #28806

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

Assignees

@sgaoshang sgaoshang

Labels

branch/enterprise-4.6 branch/enterprise-4.7 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

[enterprise-4.6] Issue in file windows_containers/creating_windows_machinesets/creating-windows-machineset-azure.adoc

6 participants

@codyhoag @openshift-docs-preview-bot @sgaoshang @openshift-ci-robot @openshift-cherrypick-robot @bergerhoffer