Skip to content

Conversation

@maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb self-assigned this Jan 25, 2021
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2021
@maxwelldb maxwelldb requested a review from iamemilio January 25, 2021 16:44
@maxwelldb
Copy link
Contributor Author

@iamemilio Any disagreements with this? It seems like clusterID isn't part of the upstream docs, so I'd assume not.

@openshift-docs-preview-bot

The preview will be available shortly at:

@maxwelldb
Copy link
Contributor Author

Taking that as a no. Promoting to QE.

@iamemilio
Copy link

lgtm

@maxwelldb
Copy link
Contributor Author

@iamemilio TY!

@maxwelldb maxwelldb removed the request for review from iamemilio January 27, 2021 15:19
@ghost
Copy link

ghost commented Feb 9, 2021

lgtm

@maxwelldb
Copy link
Contributor Author

@wjiangjay Thanks!

@maxwelldb maxwelldb added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 9, 2021
@maxwelldb
Copy link
Contributor Author

@openshift/team-documentation Small change in need of review. TY!

Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 9, 2021
@maxwelldb
Copy link
Contributor Author

@kalexand-rh TY.

@maxwelldb maxwelldb merged commit 714bd84 into openshift:master Feb 9, 2021
@maxwelldb
Copy link
Contributor Author

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #29317

Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants