Skip to content

Update SSH private key generation in the latest OKD installation documentation #29044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mburke5678 merged 1 commit into from
Feb 5, 2021
Merged

Update SSH private key generation in the latest OKD installation documentation #29044

mburke5678 merged 1 commit into from
Feb 5, 2021

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Feb 1, 2021

@mburke5678 mburke5678 added the okd-only Content that is only relevant to upstream OKD docs. label Feb 1, 2021
@mburke5678 mburke5678 added this to the Next Release milestone Feb 1, 2021
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2021
@mburke5678 mburke5678 mentioned this pull request Feb 1, 2021
Closed
@netlify
Copy link

netlify bot commented Feb 1, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit 8eb89c0

https://deploy-preview-29044--osdocs.netlify.app

@vrutkovs
Copy link

vrutkovs commented Feb 3, 2021

I think its worth using ed25519 for OCP as well - its also supported and we should encourage all users to use stronger crypto

@mburke5678
Copy link
Contributor Author

mburke5678 commented Feb 4, 2021

@staebler Can you PTAL to let me know if the installer team approves of this change? Thank you in advance.

@staebler
Copy link

staebler commented Feb 4, 2021

@staebler Can you PTAL to let me know if the installer team approves of this change? Thank you in advance.

Looks good to me. Can we make that OCP changes in this PR as well? Or does that need to be a separate PR?

staebler
staebler reviewed Feb 4, 2021
View reviewed changes
modules/ssh-agent-using.adoc Outdated
Comment on lines 120 to 121
Copy link

@staebler staebler Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a couple seconds to digest this advice. Have you seen user run this and accidentally delete ssh keys?

Suggested change
<1> Specify the path and file name, such as `~/.ssh/id_rsa`, of the SSH key.
Do not specify an existing SSH key, as it will be overwritten.
<1> Specify the path and file name, such as `~/.ssh/id_rsa`, of the SSH key to create.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2021
@mburke5678
Copy link
Contributor Author

mburke5678 commented Feb 4, 2021

@gpei Can you please review this change to the installer docs?
https://github.com/openshift/openshift-docs/pull/29044/files#diff-af0224102c27ed54d6a7f8ab652cf1b44dd9869b615e1c43d2fe193bc1b77145
https://github.com/openshift/openshift-docs/pull/29044/files#diff-5e1bb338b4de6a5ccc41c16669369a28c98826a77802fd6add6b273e4504fba2

@xiuwang Can you please review this change to the build docs?
https://github.com/openshift/openshift-docs/pull/29044/files#diff-9407125e0d62abb63cc5fb87ebfa69dc67d937ce718d392fed74b2d5159f330b

@gpei
Copy link

gpei commented Feb 5, 2021

LGTM for the installer part.

@xiuwang
Copy link

xiuwang commented Feb 5, 2021

LGTM for the build part.

@mburke5678
Copy link
Contributor Author

mburke5678 commented Feb 5, 2021

@gpei @xiuwang Thank you for your quick review!

@mburke5678
Copy link
Contributor Author

mburke5678 commented Feb 5, 2021

@codyhoag FYI

@mburke5678 mburke5678 merged commit 7c5d3a3 into openshift:master Feb 5, 2021
@mburke5678 mburke5678 deleted the okd-ssh-key-ed25519 branch February 5, 2021 14:47
@mburke5678
Copy link
Contributor Author

mburke5678 commented Feb 5, 2021 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 5, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 5, 2021 •
edited by openshift-ci-robot
Loading

@mburke5678: new pull request created: #29176

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

mburke5678 commented Feb 5, 2021 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.5

@mburke5678
Copy link
Contributor Author

mburke5678 commented Feb 5, 2021 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 5, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 5, 2021 •
edited by openshift-ci-robot
Loading

@mburke5678: new pull request created: #29177

Details

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

mburke5678 commented Feb 5, 2021 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 5, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 5, 2021 •
edited by openshift-ci-robot
Loading

@mburke5678: new pull request created: #29178

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 5, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 5, 2021 •
edited by openshift-ci-robot
Loading

@mburke5678: new pull request created: #29179

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@staebler staebler staebler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@mburke5678 @vrutkovs @staebler @gpei @xiuwang @openshift-cherrypick-robot @openshift-ci-robot