Fix curl and add configuration instructions #29155
Conversation
The curl commands failed because a directory was specified as the output. Instructions were missing for downloading or otherwise generating the checksums and configuration needed for the install-config.yaml leaving the user uncertain as to how to use the rhcos_image_cache pod or directory to make the cache usable, especially required for air-gapped deployments.
openshift-ci-robot
added
the
size/S
|
Deploy preview for osdocs ready! Built with commit af665a2 |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
@johnwilkins, any thoughts on this contributed PR? Thanks! |
|
Associated bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1925620 |
|
Looking to verify one part of it. The URL stuff we could merge in, because
we have it upstream. We need to test the rest of it.
…On Wed, May 12, 2021 at 4:21 PM Jason Boxman ***@***.***> wrote:
@johnwilkins <https://github.com/johnwilkins>, any thoughts on this
contributed PR? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29155 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALVRMLJPOPW4JEQ6U6KS4TTNMEPPANCNFSM4XDSWERA>
.
--
John Wilkins
Red Hat
***@***.***
(415) 425-9599
http://redhat.com
|
|
@bbeaudoin I have a separate PR for this here: #32588 Shashank tested it and found a need for a close quote and to change a port number from 8000 to 8080. Do you have a suggestion for who we can get on the QE team to review this? |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
I don't have a suggestion. I take the change mentioned was to match a newer podman instantiation of the pod? I took a look at the commit, looks good to me. |
|
Amit already verified it. I'm just waiting on the peer review squad to
review. Hopefully, that'll happen today. If not, we'll have to wait until
after the merge freeze.
…On Thu, Jul 1, 2021 at 10:59 AM Brian Beaudoin ***@***.***> wrote:
@bbeaudoin <https://github.com/bbeaudoin> I have a separate PR for this
here: #32588 <#32588>
Shashank tested it and found a need for a close quote and to change a port
number from 8000 to 8080. Do you have a suggestion for who we can get on
the QE team to review this?
I don't have a suggestion. I take the change mentioned was to match a
newer podman instantiation of the pod? I took a look at the commit, looks
good to me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29155 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALVRMMAOH2YPL4O33OLMDDTVSUJLANCNFSM4XDSWERA>
.
--
John Wilkins
Red Hat
***@***.***
(415) 425-9599
http://redhat.com
|
…fied as the output. Instructions were missing for downloading or otherwise generating the checksums and configuration needed for the install-config.yaml leaving the user uncertain as to how to use the rhcos_image_cache pod or directory to make the cache usable, especially required for air-gapped deployments. 29155 was supposed to fix the issue, but had a few errors itself. This resolves openshift#29155 as well
…fied as the output. Instructions were missing for downloading or otherwise generating the checksums and configuration needed for the install-config.yaml leaving the user uncertain as to how to use the rhcos_image_cache pod or directory to make the cache usable, especially required for air-gapped deployments. 29155 was supposed to fix the issue, but had a few errors itself. This resolves openshift#29155 as well
5 participants
The curl commands failed because a directory was specified as the output. Instructions were missing for downloading or otherwise generating the checksums and configuration needed for the install-config.yaml leaving the user uncertain as to how to use the rhcos_image_cache pod or directory to make the cache usable, especially required for air-gapped deployments.