Skip to content

OSDOCS-1477 Monitoring capabilities for WINC #29262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codyhoag merged 1 commit into from
Mar 2, 2021
Merged

OSDOCS-1477 Monitoring capabilities for WINC #29262

codyhoag merged 1 commit into from
Mar 2, 2021

Conversation

@codyhoag
Copy link
Contributor

@codyhoag codyhoag commented Feb 8, 2021

@codyhoag codyhoag added this to the Next Release milestone Feb 8, 2021
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2021
@netlify
Copy link

netlify bot commented Feb 8, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit 7570d6b

https://deploy-preview-29262--osdocs.netlify.app

@codyhoag
Copy link
Contributor Author

codyhoag commented Feb 8, 2021

@aravindhp @VaishnaviHire can one of you confirm this Monitoring note? Thanks!

aravindhp
aravindhp reviewed Feb 8, 2021
View reviewed changes
@VaishnaviHire
Copy link

VaishnaviHire commented Feb 8, 2021

@codyhoag Thanks for adding the note.

LGTM

@codyhoag codyhoag force-pushed the wmco-monitoring-note branch from dba8d8a to b0eac0d Compare February 8, 2021 21:20
@codyhoag
Copy link
Contributor Author

codyhoag commented Feb 8, 2021

@sgaoshang can you verify from a QE perspective? Thanks!

@sgaoshang
Copy link

sgaoshang commented Feb 9, 2021

@codyhoag Thanks for the note, looks good from me.

@sgaoshang
Copy link

sgaoshang commented Feb 9, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
@codyhoag codyhoag added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 9, 2021
adellape
adellape reviewed Feb 9, 2021
View reviewed changes
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 9, 2021
@codyhoag codyhoag force-pushed the wmco-monitoring-note branch from b0eac0d to bc35df7 Compare February 9, 2021 15:26
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2021
@codyhoag codyhoag mentioned this pull request Feb 9, 2021
Merged
@codyhoag codyhoag added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2021
@codyhoag
Copy link
Contributor Author

codyhoag commented Feb 9, 2021

This is dependent on the WMCO 2.x release, which is independent from the OCP 4.7 release. This must hold until the WMCO is available (targeting near OCP 4.7 release).

@codyhoag codyhoag force-pushed the wmco-monitoring-note branch from 665e009 to 7570d6b Compare March 1, 2021 20:04
@codyhoag codyhoag removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2021
@codyhoag
Copy link
Contributor Author

codyhoag commented Mar 2, 2021

Advisory for WMCO has shipped live.

@codyhoag codyhoag merged commit 4094e0d into openshift:master Mar 2, 2021
@codyhoag
Copy link
Contributor Author

codyhoag commented Mar 2, 2021

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 2, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 2, 2021

@codyhoag: new pull request created: #29974

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag
Copy link
Contributor Author

codyhoag commented Mar 2, 2021

/cherrypick enterprise-4.7

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Mar 2, 2021

@codyhoag: new pull request created: #29975

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@adellape adellape adellape left review comments

@aravindhp aravindhp aravindhp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sgaoshang sgaoshang

Labels

branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@codyhoag @VaishnaviHire @sgaoshang @openshift-ci-robot @openshift-cherrypick-robot @adellape @aravindhp