Skip to content

Conversation

@rishumehra
Copy link
Contributor

Changed text "Topology view" to "Graph view" in the documentation.

For Openshift 4.7

This change is based on the dev issue: https://issues.redhat.com/browse/ODC-5355

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 9, 2021
@netlify
Copy link

netlify bot commented Feb 9, 2021

Deploy preview for osdocs ready!

Built with commit 4587c2c

https://deploy-preview-29290--osdocs.netlify.app

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The *Topology* view in the *Developer* perspective of the web console provides the following options to interact with applications and components:
The *Topology* page in the *Developer* perspective of the web console provides the following options to interact with applications and components:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Serverless applications take some time to load and display on the *Graph view*. When you create a serverless application, it first creates a service resource and then a revision. After that, it is deployed and displayed on the *Graph view*. If it is the only workload, you might be redirected to the *Add* page. After the revision is deployed, the serverless application is displayed on the *Graph view*.
Serverless applications take some time to load and display on the *Graph view*. When you deploy a serverless application, it first creates a service resource and then a revision. After that, it is deployed and displayed on the *Graph view*. If it is the only workload, you might be redirected to the *Add* page. After the revision is deployed, the serverless application is displayed on the *Graph view*.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can navigate to the *Topology* view using the left navigation panel in the *Developer* perspective. After you create an application, you are directed automatically to the *Graph view* where you can see the status of the application pods, quickly access the application on a public URL, access the source code to modify it, and see the status of your last build. You can zoom in and out to see more details for a particular application.
You can navigate to the *Topology* page using the left navigation panel in the *Developer* perspective. After you deploy an application, you are directed automatically to the *Graph view* where you can see the status of the application pods, quickly access the application on a public URL, access the source code to modify it, and see the status of your last build. You can zoom in and out to see more details for a particular application.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The *Topology* view also provides you the option to monitor your applications using the *List* view. Use the *List view* icon (image:odc_list_view_icon.png[title="List view icon"]) to see a list of all your applications and use the *Graph view* icon (image:odc_topology_view_icon.png[title="Topology view icon"]) to switch back to the graph view.
The *Topology* page also provides you the option to monitor your applications using the *List* view. Use the *List view* icon (image:odc_list_view_icon.png[title="List view icon"]) to see a list of all your applications and use the *Graph view* icon (image:odc_topology_view_icon.png[title="Topology view icon"]) to switch back to the graph view.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... the Shortcuts menu is NEXT to the icon, it's not the name of the icon. it's a different interaction point.

Maybe something like:

Suggested change
* Use the *Shortcuts* menu on the upper-right of the screen to navigate components in the *Graph view*.
* Use the icon (<insert the icon here>) in the upper-right of the screen to navigate components in the *Graph view*.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2021
@rishumehra
Copy link
Contributor Author

rishumehra commented Feb 9, 2021

@andrewballantyne As discussed with you over slack I have dropped the Shortcuts menu bullet point as it is not marking any major functionality.

@gajanan-more After having a discussion with @Preeticp we finalized to retain the "Topology view" as is. Otherwise, we need to make the same change to the whole documentation.

@andrewballantyne @gajanan-more @Preeticp Kindly check the changes in the new commit. If no further changes are required then please merge this PR.

Copy link

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gajanan-more
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2021
@ahardin-rh ahardin-rh added this to the Future Release milestone Feb 10, 2021
@ahardin-rh ahardin-rh added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR labels Feb 10, 2021
@ahardin-rh
Copy link
Contributor

LGTM! We just need to squash your commits down to one and we should be good to go. Thank you!

…t as text wherever required. Also removed the line about Shortcuts menu, as discussed with Andrew.
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2021
@rishumehra
Copy link
Contributor Author

LGTM! We just need to squash your commits down to one and we should be good to go. Thank you!

@ahardin-rh Squashed commits now. Please go ahead and merge the PR now. Thanks for the review.

@ahardin-rh ahardin-rh merged commit aee1fcd into openshift:master Feb 10, 2021
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.7

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #29347

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants